Last modified: 2012-09-19 20:52:31 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T38079, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 36079 - refreshWikiversionsCDB should fail if invalid version is specified in wikiversions.dat
refreshWikiversionsCDB should fail if invalid version is specified in wikiver...
Status: RESOLVED FIXED
Product: Wikimedia
Classification: Unclassified
General/Unknown (Other open bugs)
unspecified
All All
: High enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
: platformeng
Depends on:
Blocks: 36464
  Show dependency tree / graph
 
Reported: 2012-04-18 22:08 UTC by Rob Lanphier
Modified: 2012-09-19 20:52 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Rob Lanphier 2012-04-18 22:08:58 UTC 
Currently, it's possible to put this into wikiversions.dat:
enwiki php-1.onemillonandsomething

...even though this file:
/usr/local/apache/common-local/php-1.onemillonandsomething/index.php

...doesn't exist and hopefully never will.  That means running refreshWikiversionsCDB will cause a fatal on the enwiki homepage.

Solution: do a sanity check prior to building the cdb file, and make sure that for each specified version "foo", that this file exists:

/usr/local/apache/common-local/foo/index.php

...and exit with a fatal error if it doesn't, leaving the cdb file unscathed.
Comment 1 Tim Starling 2012-04-19 01:05:04 UTC 
Also could we use trigger_error(..., E_USER_ERROR) instead of die() in multiversion? That way, users would see a nicer-looking error message, and more importantly, the error would be logged.
Comment 2 Rob Lanphier 2012-04-19 01:41:11 UTC 
Filed comment 1 as bug 36083
Comment 3 Aaron Schulz 2012-04-19 21:15:15 UTC 
Done in r114978.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links