Last modified: 2014-02-28 18:14:20 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T38069, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 36069 - Make command-line installer to read admin password and install db user password from files
Make command-line installer to read admin password and install db user passwo...
Status: UNCONFIRMED
Product: MediaWiki
Classification: Unclassified
Installer (Other open bugs)
1.18.x
All All
: Normal enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
: patch, patch-reviewed
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-04-18 17:28 UTC by Kevan Carstensen
Modified: 2014-02-28 18:14 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Patch that adds new options to the command line installer (3.91 KB, text/plain)
2012-04-18 17:28 UTC, Kevan Carstensen
Details

Description Kevan Carstensen 2012-04-18 17:28:48 UTC
Created attachment 10430 [details]
Patch that adds new options to the command line installer

The command-line installer has a dbpassfile option, which can be used to avoid specifying the password for the database user in plaintext on the command line, as one would do with the dbpass option. It would be nice if there were a way to do that for the pass and installdbpass options as well. I've attached a patch against the current git master that does this. I'm running a similar modification on 1.18.2 at my site to get this functionality.
Comment 1 Amgine 2012-06-22 22:25:07 UTC
This enhancement is related to #26911.
Comment 2 Tim Landscheidt 2012-09-26 18:48:26 UTC
Kevan, do you have a Labs account to submit this to Gerrit yourself?
Comment 3 Andre Klapper 2013-03-13 10:51:22 UTC
Kevan: Thanks for your patch!

You are welcome to use Developer access
  https://www.mediawiki.org/wiki/Developer_access
to submit this as a Git branch directly into Gerrit:
  https://www.mediawiki.org/wiki/Git/Tutorial

Putting your branch in Git makes it easier to review it quickly.
Thanks again! We appreciate your contribution.
Comment 4 Andre Klapper 2014-02-28 18:14:20 UTC
(In reply to Kevan Carstensen from comment #0)
> Created attachment 10430 [details]
> Patch that adds new options to the command line installer

Tried to put the patch into Gerrit via http://tools.wmflabs.org/gerrit-patch-uploader/ but patch needs rework:

patch -p1 < patch 
patching file maintenance/install.php 
Hunk #1 FAILED at 69. 
1 out of 1 hunk FAILED -- saving rejects to file maintenance/install.php.rej 
patching file maintenance/install.php 
Hunk #1 FAILED at 40. 
Hunk #2 succeeded at 60 (offset 6 lines). 
Hunk #3 FAILED at 70. 
2 out of 3 hunks FAILED -- saving rejects to file maintenance/install.php.rej

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links