Last modified: 2012-09-19 20:55:16 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T37939, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 35939 - 1.19/1.20 wgResourceBasePath hack for accessing resourceloader /w/resources/ problems
1.19/1.20 wgResourceBasePath hack for accessing resourceloader /w/resources/ ...
Status: RESOLVED FIXED
Product: Wikimedia
Classification: Unclassified
General/Unknown (Other open bugs)
wmf-deployment
All All
: Normal major (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks: 36465
  Show dependency treegraph
 
Reported: 2012-04-13 01:40 UTC by Krinkle
Modified: 2012-09-19 20:55 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Comment 1 Rob Lanphier 2012-04-18 15:46:08 UTC
Explanation hashed out in http://etherpad.wikimedia.org/bug35939

== Current situation ==
skins/
    (site).org/w/skins-$version --> common/php-$version/skins
    $wgStylePath / $wgStyleDirectory
extensions
    (site).org/w/extensions-$version --> common/php-$version/extensions
    $wgExtensionAssetsPath
resources/
    (site).org/w/resources-$version --> common/php-$version
    $wgResourcesPath/resources


== Proposed solution (1) ==
Phasing out wgStylePath and wgExtensionAssetsPath, instead make broader use of wgResourceBasePath

skins/
    (site).org/w-$version/skins --> common/php-$version/skins
    $wgResourceBasePath/skins
extensions
    (site).org/w-$version/extensions --> common/php-$version/extensions
    $wgResourceBasePath/extensions
resources/
    (site).org/w-$version/resources --> common/php-$version/resources
    $wgResourceBasePath/resources


== Proposed solution (2) ==
(bug 31173) Implement wgResourcesPath / wgResourcesDirectory

skins/
    (site).org/w/skins-$version --> common/php-$version/skins
    $wgStylePath / $wgStyleDirectory
extensions
    (site).org/w/extensions-$version --> common/php-$version/extensions
    $wgExtensionAssetsPath
resources/
    (site).org/w/resources-$version --> common/php-$version/resources
    $wgResourcesPath /wgResourcesDirectory

Moving the milestone to 1.20wmf2.  We may kick this one down the road a little bit if we don't get to it immediately.  It should not be an emergency blocker for a deployment; just something that we need to get fixed.
Comment 2 Krinkle 2012-04-18 22:02:22 UTC
We're going with (1);

== Proposed solution (1) ==
Phasing out wgStylePath and wgExtensionAssetsPath, instead make broader use of wgResourceBasePath

skins/
* (site).org/w/static-$version/skins --> (common)/php-$version/skins
* Usage: $wgResourceBasePath/skins
extensions
* (site).org/w/static-$version/extensions --> (common)/php-$version/extensions
* Usage: $wgResourceBasePath/extensions
resources/
* (site).org/w/static-$version/resources --> (common)/php-$version/resources
* Usage: $wgResourceBasePath/resources
Comment 3 Krinkle 2012-04-18 22:05:35 UTC
Fixed in r114955.

The symlinks will be generated from the next version on. The usage will not be incorporated as described above in the software, instead local configurations can set existing variables to it if they want to use a central bits location like WMF has:

$wgResourceBasePath = '//bits.wikimedia.org/static-{$mwVersion}';
$wgStylePath = "{$wgResourceBasePath}/skins";
$wgExtensionAssetsPath = {$wgResourceBasePath}/extensions";
// and resources is already naturally handled by ResourceLoader using wgResourceBasePath as root through "$wgResourceBasePath/resources".

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links