Last modified: 2012-04-03 18:12:13 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T37671, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 35671 - PHP Notice: Undefined index: gettoken in includes/api/ApiMain.php on line 598
PHP Notice: Undefined index: gettoken in includes/api/ApiMain.php on line 598
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
API (Other open bugs)
1.20.x
All All
: Highest normal (vote)
: ---
Assigned To: Antoine "hashar" Musso (WMF)
:
Depends on:
Blocks: 35676
  Show dependency treegraph
 
Reported: 2012-04-03 16:05 UTC by Niklas Laxström
Modified: 2012-04-03 18:12 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Niklas Laxström 2012-04-03 16:05:52 UTC
PHP Notice:  Undefined index: gettoken in /www/w/includes/api/ApiMain.php on line 598

Probable cause is https://gerrit.wikimedia.org/r/#change,3434
Comment 1 Sam Reed (reedy) 2012-04-03 16:19:17 UTC
Yay to whoever added gettoken only on few modules



if ( $salt !== false && !$moduleParams['gettoken'] ) {

to

if ( $salt !== false && isset( $moduleParams['gettoken'] ) && !$moduleParams['gettoken'] ) {


I guess...
Comment 2 Antoine "hashar" Musso (WMF) 2012-04-03 17:24:49 UTC
comment 1 would bring back bug 34212

See commit message of  https://gerrit.wikimedia.org/r/#change,4159
Comment 3 Sam Reed (reedy) 2012-04-03 17:28:05 UTC
(In reply to comment #2)
> comment 1 would bring back bug 34212
> 
> See commit message of  https://gerrit.wikimedia.org/r/#change,4159

We're still doing the check on the value, but only if we have that parameter set, and hence something to check the value of...
Comment 4 Sam Reed (reedy) 2012-04-03 18:04:46 UTC
I just tested it, that fix works fine, and doesn't regress on bug 34212
Comment 5 Sam Reed (reedy) 2012-04-03 18:07:07 UTC
https://gerrit.wikimedia.org/r/4192

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links