Last modified: 2012-03-20 16:58:00 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T37283, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 35283 - Duplication of defaults in wgAddGroups/wgRemoveGroups


Summary:	Duplication of defaults in wgAddGroups/wgRemoveGroups

Status:	RESOLVED FIXED

Product:	Wikimedia
Classification:	Unclassified
Component:	Site requests (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	Low normal (vote)
Target Milestone:	---
Assigned To:	Nobody - You can work on this!

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:	28141
	Show dependency tree / graph

Reported:	2012-03-17 16:55 UTC by Ruslan
Modified:	2012-03-20 16:58 UTC (History)
CC List:	2 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Ruslan 2012-03-17 16:55:36 UTC

Just after wgAddGroups in InitialiseSettings.php there is a good advice from Werdna:

"The '+' in front of the DB name means 'add to the default'. It saves us duplicating changes to the default across all overrides"

Unfortunately it is not followed as there are lots of duplicating entries. A clean-up is evidently needed.

Could all duplications be removed? Namely 'sysop', 'bureaucrat' and 'bot' should be removed from bureaucrat's entries and 'ipblock-exempt' from sysop's ones in wgAddGroups and also 'bot' should be removed from bureaucrat's and 'ipblock-exempt' from sysop's in wgRemoveGroups.

In its current form the configuration file is confusing, which may lead to copy-paste errors while updating configuration.

Thank you in advance.

Comment 1 Sam Reed (reedy) 2012-03-17 21:31:44 UTC

If you want to tidy it all up and paste it here, I'll review and apply it! :P

Else I will get around to it at somepoint

Comment 2 Sam Reed (reedy) 2012-03-17 22:56:04 UTC

Similar needs doing for group overrides...

Comment 3 Sam Reed (reedy) 2012-03-17 23:12:11 UTC

I've done add and remove groups for bureaucrat so far...

Comment 4 Sam Reed (reedy) 2012-03-17 23:18:06 UTC

And also for sysop...

Comment 5 Ruslan 2012-03-18 05:54:29 UTC

Thank you for your work. But

in wgAddGroups see: incubatorwiki and noboard_chapterswikimedia,

in wgRemoveGroups see: outreachwiki and ruwiki.

Comment 6 Sam Reed (reedy) 2012-03-20 14:58:53 UTC

(In reply to comment #5)
> Thank you for your work. But
> 
> in wgAddGroups see: incubatorwiki and noboard_chapterswikimedia,
> 
> in wgRemoveGroups see: outreachwiki and ruwiki.

Done also

Comment 7 Ruslan 2012-03-20 16:58:00 UTC

Marked as fixed.

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links