Last modified: 2012-11-23 23:14:03 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T37272, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 35272 - Account creation messages inconsistent
Account creation messages inconsistent
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
General/Unknown (Other open bugs)
unspecified
All All
: Low trivial (vote)
: ---
Assigned To: Nobody - You can work on this!
: i18n
Depends on:
Blocks: messages
  Show dependency treegraph
 
Reported: 2012-03-16 22:53 UTC by Alex Monk
Modified: 2012-11-23 23:14 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Alex Monk 2012-03-16 22:53:58 UTC
The logentry-newusers-newusers-* messages are inconsistent:

'logentry-newusers-newusers' => '$1 created a user account',
'logentry-newusers-create' => '$1 created a user account',
'logentry-newusers-create2' => '$1 created a user account $3',
'logentry-newusers-autocreate' => 'Account $1 was created automatically',

Either 'Account' should be appended to the start of the non-autocreate messages, or it should be removed from the autocreate one.
Comment 1 Dan Collins 2012-03-17 02:28:55 UTC
I don't see the inconsistency. In the first three there was an active action of registering committed by $1, so it's written in the active voice. In the last one the passive voice is used because $1 did not perform any active action worthy of a log action, he just tried to log in on a new wiki. Since it's a different message referring to a different event (new registration vs SUL first time on this wiki) it makes sense for the messages to be different?
Comment 2 Alex Monk 2012-03-17 10:57:23 UTC
It makes sense for them to be different in that it marks automatically created accounts as '$1 was created automatically'. But the 'Account' bit is just unnecessary and makes the messages inconsistent.
Comment 3 Nemo 2012-07-25 09:44:02 UTC
Are you sure that you're not mixing old and new logging system' messages? Niklas would know.
Comment 4 Alex Monk 2012-10-27 18:33:15 UTC
These are all listed under "# New logging system" in languages/messages/MessagesEn.php.

Gerrit change #30360

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links