Last modified: 2012-05-03 02:42:41 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T36963, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 34963 - Moving sha1 into revision tag in XML dumps
Moving sha1 into revision tag in XML dumps
Product: MediaWiki
Classification: Unclassified
Export/Import (Other open bugs)
All All
: Normal enhancement (vote)
: 1.19.0 release
Assigned To: Aaron Schulz
: patch, patch-need-review
: 35265 (view as bug list)
Depends on:
Blocks: 31217
  Show dependency treegraph
Reported: 2012-03-04 18:41 UTC by christian
Modified: 2012-05-03 02:42 UTC (History)
7 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Moves SHA1 sums into revision tags (985 bytes, patch)
2012-03-04 18:41 UTC, christian

Description christian 2012-03-04 18:41:11 UTC
Created attachment 10172 [details]
Moves SHA1 sums into revision tags

Currently, each /page/ tag has the sha1 sum of the first (i.e.: not necessarily current) /revision/'s text added. The revision tags do not come with SHA1 tags.

While there is nothing wrong with this, the export-0.6 XML schema requires the SHA1 sum of each revision to be stored within the corresponding /revision/ tag itself.

The supplied patch moves the sha1 sum from the page tag to the revision tag.
Comment 1 db [inactive,noenotif] 2012-03-05 17:32:31 UTC
See r109848#c31769, making this under 1.19, because it is new in 1.19 and should by fixed now, to have the xsd and xml matched closure each other.
Comment 2 db [inactive,noenotif] 2012-03-09 21:00:12 UTC
It is nice to get this fixed now, because than there is no problem with b/c in some years (or want you add this to page and revision for b/c? That makes the dump bigger, please avoid that). The xsd already says it is at the revision and the value is in the database for each revision. There is no reason do not move the lines from one method to the other.
Comment 3 Mormegil 2012-03-16 16:00:10 UTC
*** Bug 35265 has been marked as a duplicate of this bug. ***
Comment 4 Rob Lanphier 2012-03-16 19:00:18 UTC
Marking 1.19wmf1 since we will likely backport this.
Comment 5 Aaron Schulz 2012-03-28 17:28:05 UTC
Done in I0d943389.

Note You need to log in before you can comment on or make changes to this bug.