Last modified: 2012-06-02 03:34:12 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T36942, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 34942 - Add a show Headers preference
Add a show Headers preference
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
ProofreadPage (Other open bugs)
unspecified
All All
: Normal minor (vote)
: ---
Assigned To: ThomasV
: patch, patch-need-review
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2012-03-03 18:16 UTC by Tpt
Modified: 2012-06-02 03:34 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Correction (2.83 KB, patch)
2012-03-03 18:16 UTC, Tpt 		Details
Add an attachment (proposed patch, testcase, etc.)

Description Tpt 2012-03-03 18:16:47 UTC 
Created attachment 10167 [details]
Correction

Many Wikisource use a pr headers gadget in order to set an option that show by default the header and footer of pages of the Page namespace. This gadget set to true a JS variable used by proofreadpage extension. But, with RessourceLoader 2, this gadget is often loaded after extension JS, and doesn't work.

This patch solve the problem by adding a checkbox in editing preferences.
Comment 1 Zaran 2012-03-09 05:53:38 UTC 
I agree it will be cleaner to have an option to set this in user preferences. However, does it work if you add ext.proofreadpage.page as a dependency of the gadget?
Comment 2 Tpt 2012-03-09 18:53:02 UTC 
No, it doesn't because it is ext.proofreadpage.page that depends on the gadget.

See : https://fr.wikisource.org/w/index.php?title=MediaWiki%3AGadgets-definition&diff=3301228&oldid=3301223
Comment 3 Zaran 2012-03-16 09:08:58 UTC 
Ok. Patch applied in r114004
Comment 4 MZMcBride 2012-06-02 03:34:12 UTC 
(In reply to comment #3)
> Ok. Patch applied in r114004

For reference, this was reverted in r114398 and then re-merged in <https://gerrit.wikimedia.org/r/3466>.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links