Last modified: 2010-05-15 15:37:29 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T5487, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 3487 - Category contents is not shown if the preview is at the bottom
Category contents is not shown if the preview is at the bottom
Product: MediaWiki
Classification: Unclassified
Page editing (Other open bugs)
All All
: Normal minor with 2 votes (vote)
: ---
Assigned To: Nobody - You can work on this!
Depends on:
Blocks: html
  Show dependency treegraph
Reported: 2005-09-17 12:43 UTC by Dave Miller (ProgMania)
Modified: 2010-05-15 15:37 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Description Dave Miller (ProgMania) 2005-09-17 12:43:04 UTC
$wgOut->addHTML( '<div id="wikiPreview">' );
if ( 'preview' == $formtype) {
	$previewOutput = $this->getPreviewText( $isConflict, $isCssJsSubpage );
	if ( $wgUser->getOption('previewontop' ) ) {
		$wgOut->addHTML( $previewOutput );
		if($this->mTitle->getNamespace() == NS_CATEGORY) {
		$wgOut->addHTML( "<br style=\"clear:both;\" />\n" );
$wgOut->addHTML( '</div>' );

if ( $formtype == 'preview' && !$wgUser->getOption( 'previewontop' ) ) {
	$wgOut->addHTML( '<div id="wikiPreview">' . $previewOutput . '</div>' );

I.e. this is missing:
	if($this->mTitle->getNamespace() == NS_CATEGORY) {

Also, if it's at the bottom. "<div id="wikiPreview"></div>" is still output at the top, resulting 
in two divs with the same id. (I don't know if this causes a problem for scripting or not but it's 
still unnecessary.)

(I also noticed openShowCategory() not called - although it is currently blank, if anything was 
added to it then the preview would be different to the action view.)
Comment 1 Brion Vibber 2005-11-03 22:44:25 UTC
Fixed in HEAD for 1.6.

Note You need to log in before you can comment on or make changes to this bug.