Last modified: 2012-05-03 02:42:40 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
First Last Prev Next    This bug is not in your last search results.
Bug 34849 - diff during editing an old version compares not to the current but to the old version
diff during editing an old version compares not to the current but to the old...
Status: VERIFIED FIXED
Product: MediaWiki
Classification: Unclassified
History/Diffs (Other open bugs)
1.19
All All
: High normal (vote)
: 1.19.0 release
Assigned To: Nobody - You can work on this!
http://commons.wikimedia.org/w/index....
:
Depends on:
Blocks: 31217
  Show dependency tree / graph
 
Reported: 2012-03-01 13:26 UTC by Saibo
Modified: 2012-05-03 02:42 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Saibo 2012-03-01 13:26:37 UTC 
See [[:commons:Commons:Village pump#MW1.19 - editing old revision and "show changes" does not work]] for maybe more comments by other users. 

Test: [//commons.wikimedia.org/w/index.php?title=File:P1000372_dsdssdd_ds.JPG&action=edit&oldid=61901086 edit], click compare button below the edit window. Expected: for example the first two "wrong licensing" lines should appear as deleted in the diff.

Editing works - but the comparision apparently compares not with the current version (like before 1.19) but with the version you had edited. That is not useful since what will be overwritten when the save is done is the current version.
Comment 2 Antoine "hashar" Musso (WMF) 2012-03-01 16:50:02 UTC 
Confirmed. Step to reproduce:

create a new page with text:  "this is first revision". Save page.

Edit page and append text "this is second revision". Save page.

Browse to history, select the oldest revision. The loaded page show "this is first revision".

Edit page and append "this is third revision". Press [Show change]

The diff loaded  is:

  This is the very first revision.
+ This is third revision

It does not show the removal of the second revision text.
Comment 3 Antoine "hashar" Musso (WMF) 2012-03-01 17:14:59 UTC 
cause by some change in r102997 by iAlex which cleaned up Article::view()
Comment 4 Alexandre Emsenhuber [IAlex] 2012-03-01 17:29:32 UTC 
Fixed in r112819.
Comment 5 Antoine "hashar" Musso (WMF) 2012-03-01 17:36:14 UTC 
Merged in 1.19wmf1 by r112821 and deployed live.
Comment 6 Saibo 2012-03-01 20:09:47 UTC 
Confirmed, my testcase works. thanks!
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links