Last modified: 2012-05-03 02:42:40 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T36849, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 34849 - diff during editing an old version compares not to the current but to the old version
diff during editing an old version compares not to the current but to the old...
Product: MediaWiki
Classification: Unclassified
History/Diffs (Other open bugs)
All All
: High normal (vote)
: 1.19.0 release
Assigned To: Nobody - You can work on this!
Depends on:
Blocks: 31217
  Show dependency treegraph
Reported: 2012-03-01 13:26 UTC by Saibo
Modified: 2012-05-03 02:42 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Description Saibo 2012-03-01 13:26:37 UTC
See [[:commons:Commons:Village pump#MW1.19 - editing old revision and "show changes" does not work]] for maybe more comments by other users. 

Test: [// edit], click compare button below the edit window. Expected: for example the first two "wrong licensing" lines should appear as deleted in the diff.

Editing works - but the comparision apparently compares not with the current version (like before 1.19) but with the version you had edited. That is not useful since what will be overwritten when the save is done is the current version.
Comment 2 Antoine "hashar" Musso (WMF) 2012-03-01 16:50:02 UTC
Confirmed. Step to reproduce:

create a new page with text:  "this is first revision". Save page.

Edit page and append text "this is second revision". Save page.

Browse to history, select the oldest revision. The loaded page show "this is first revision".

Edit page and append "this is third revision". Press [Show change]

The diff loaded  is:

  This is the very first revision.
+ This is third revision

It does not show the removal of the second revision text.
Comment 3 Antoine "hashar" Musso (WMF) 2012-03-01 17:14:59 UTC
cause by some change in r102997 by iAlex which cleaned up Article::view()
Comment 4 Alexandre Emsenhuber [IAlex] 2012-03-01 17:29:32 UTC
Fixed in r112819.
Comment 5 Antoine "hashar" Musso (WMF) 2012-03-01 17:36:14 UTC
Merged in 1.19wmf1 by r112821 and deployed live.
Comment 6 Saibo 2012-03-01 20:09:47 UTC
Confirmed, my testcase works. thanks!

Note You need to log in before you can comment on or make changes to this bug.