Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T36809, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 34809 - CentralNotice: ResourceLoader-ify Special:BannerController

Summary:	CentralNotice: ResourceLoader-ify Special:BannerController

Status: RESOLVED FIXED Product: MediaWiki extensions Classification: Unclassified Component: CentralNotice (Other open bugs) Version: unspecified Hardware: All All Importance: Normal enhancement (vote) Target Milestone: --- Assigned To: Nobody - You can work on this! URL: https://developers.google.com/pagespe... Whiteboard: Keywords: fun-com, fundraising Depends on: Blocks: 29713   Show dependency tree / graph		Reported: 2012-02-29 20:05 UTC by Sam Reed (reedy) Modified: 2012-09-25 19:03 UTC (History) CC List: 4 users (show) amir.aharoni fr-tech pgehres rkaldari See Also: Web browser: --- Mobile Platform: --- Assignee Huggle Beta Tester: ---

Attachments Add an attachment (proposed patch, testcase, etc.)

Description Sam Reed (reedy) 2012-02-29 20:05:14 UTC Related to/follow on of bug 29239 According to googles page speed analysis (see linked url): https://en.wikipedia.org/w/index.php?title=Special:BannerController&cache=/cn.js&303-4 could save 571B (11% reduction) after compression Also https://en.wikipedia.org/w/index.php?title=Special:BannerController&cache=/cn.js&303-4 is missing a cache validator ResourceLoader-ifying Special:BannerController should be enough to fix both of these! Comment 1 Ryan Kaldari 2012-02-29 20:49:39 UTC Can you include Special pages in module definitions? I was under the impression you could only use static js files. Comment 2 Ryan Kaldari 2012-03-02 20:48:37 UTC I suppose we could move all the variable pieces to a separate Special page and make the BannerController a static file. Comment 3 Ryan Kaldari 2012-09-25 19:02:38 UTC Fixed a while back.