Last modified: 2012-05-03 02:45:53 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T36706, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 34706 - Side-by-side functionality broken in Chrome and possibly some Internet Explorer
Side-by-side functionality broken in Chrome and possibly some Internet Explorer
Product: MediaWiki extensions
Classification: Unclassified
ProofreadPage (Other open bugs)
All All
: High major (vote)
: MW 1.19 version
Assigned To: ThomasV
Depends on:
Blocks: 31217
  Show dependency treegraph
Reported: 2012-02-25 12:27 UTC by billinghurst
Modified: 2012-05-03 02:45 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Description billinghurst 2012-02-25 12:27:59 UTC
Following the update to 1.19wmf1 English Wikisource has a break in the side by side viewing of text and image.  This basically prevents all use of affected browsers from this functionality. Mostly seems related to vector skin. [Note that FF 10.0.2 unaffected]

Default skin of vector 






Also seeing some image load and lag issues on the pages, presumably related

Error log when loading page in vector (not no errors when loading in monobook)

Uncaught TypeError: Object [object Object] has no method 'addSource'
(anonymous function)load.php:151
load.php:142Uncaught TypeError: Cannot read property 'options' of undefined
(anonymous function)index.php:27
index.php:1127Uncaught TypeError: Cannot call method 'addButton' of undefined
(anonymous function)index.php:1127
(anonymous function)index.php:1127
index.php:41Uncaught ReferenceError: addOnloadHook is not defined
(anonymous function)index.php:41
load.php:5Uncaught ReferenceError: addOnloadHook is not defined
(anonymous function)load.php:5
index.php:198Uncaught ReferenceError: addOnloadHook is not defined
(anonymous function)index.php:198
index.php:94Uncaught ReferenceError: addOnloadHook is not defined
(anonymous function)index.php:94
index.php:75Uncaught ReferenceError: addOnloadHook is not defined
(anonymous function)index.php:75
index.php:109Uncaught ReferenceError: addOnloadHook is not defined
(anonymous function)index.php:109
index.php:95Uncaught ReferenceError: hookEvent is not defined
(anonymous function)index.php:95
index.php:83Uncaught ReferenceError: addOnloadHook is not defined
(anonymous function)index.php:83
index.php:86Uncaught TypeError: Cannot call method 'wikiScript' of undefined
(anonymous function)index.php:152
Comment 1 Roan Kattouw 2012-02-26 00:16:24 UTC
The core error is 'mw.loader.addSource is not defined', and that was quite clearly caused by the 1.18 version of mw.loader being served from cache. For some reason the cache for mediawiki.js wasn't invalidated on enwikisource, I don't know exactly why, or why this didn't happen to the other wikis that we deployed 1.19 to.

My best guess is that not all servers switched enwikisource to 1.19 at the exact same time, so that the following sequence of events could happen:
1) client requests startup module for enwikisource
2) server running 1.19 serves response, Varnish caches it
3) client requests mediawiki module with the updated timestamp in the URL
4) server running 1.18 serves response, Varnish caches it
5) a little while later, all servers run 1.19 for enwikisource, but Varnish is still caching 1.18 versions of modules with 1.19 URLs

I ran purge-varnish , which purges all URLs with '' anywhere in them from Varnish (in practice that's all URLs). After doing that, a hard refresh fixed the issue for me.

I guess we should probably do a Varnish purge for a wiki every time we deploy a completely new version of MediaWiki to it, to prevent this kind of bug from happening.
Comment 2 Rob Lanphier 2012-02-27 19:19:14 UTC
I confirmed that this works for me now.  billinghurst, please reopen this if it doesn't appear to work for you now.

Note You need to log in before you can comment on or make changes to this bug.