Last modified: 2005-10-13 00:52:10 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T5469, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 3469 - Allpages and Prefixindex both use message 'allpagesfrom'


Summary:	Allpages and Prefixindex both use message 'allpagesfrom'

Status:	RESOLVED FIXED

Product:	MediaWiki
Classification:	Unclassified
Component:	Internationalization (Other open bugs)
Version:	1.6.x
Hardware:	All All

Importance:	Low minor with 1 vote (vote)
Target Milestone:	---
Assigned To:	Nobody - You can work on this!

URL:
Whiteboard:
Keywords:	patch, patch-need-review

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2005-09-15 08:21 UTC by Henning Heitkötter
Modified:	2005-10-13 00:52 UTC (History)
CC List:	0 users

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Introducing 'allpagesprefix' (1.62 KB, patch) 2005-09-15 08:22 UTC, Henning Heitkötter	Details
Unified Patch (2.85 KB, patch) 2005-10-12 15:50 UTC, Henning Heitkötter	Details
Show Obsolete (1) Add an attachment (proposed patch, testcase, etc.)

Description Henning Heitkötter 2005-09-15 08:21:28 UTC

Special:Allpages and Special:Prefixindex both use MediaWiki-Message
'allpagesfrom' (default: "Display pages starting at:") for labelling the input
field 'nsfrom'. As these specialpages perform different search queries, the
input in this field has a different meaning in each case: Allpages lists all
pages with a title >= $from, while Prefixindex narrows the result on pages
*beginning* with $from (LIKE $from%).
Therefore they should use different MediaWiki messages, so that the difference
becomes obvious for the user.

Patch follows.

Comment 1 Henning Heitkötter 2005-09-15 08:22:46 UTC

Created attachment 896 [details]
Introducing 'allpagesprefix'

This patch provides the described behaviour. Both classes SpecialAllpages and
SpecialPrefixindex get a class variable $nsfromMsg determing the
MediaWiki-message to use, used by namespaceForm(). Allpages uses
'allpagesfrom', Prefixindex the new 'allpagesprefix' (In Language.php, already
translated for German).
The change requires a rebuildMessages.php --update because of the new message.

Comment 2 Ævar Arnfjörð Bjarmason 2005-10-01 10:36:37 UTC

Please submit a unified diff, see
http://meta.wikimedia.org/wiki/MediaWiki_localisation#Create_a_patch for details
on how to do that.

Comment 3 Henning Heitkötter 2005-10-12 15:50:35 UTC

Created attachment 982 [details]
Unified Patch

Comment 4 Brion Vibber 2005-10-13 00:52:10 UTC

Applied to CVS HEAD.

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links