Last modified: 2012-05-03 02:42:45 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 34466 - All sections in Preferences visible
All sections in Preferences visible
Product: MediaWiki
Classification: Unclassified
User preferences (Other open bugs)
All All
: High normal (vote)
: 1.19.0 release
Assigned To: Nobody - You can work on this!
: javascript
Depends on:
Blocks: 31217
  Show dependency treegraph
Reported: 2012-02-17 09:29 UTC by Michael M.
Modified: 2012-05-03 02:42 UTC (History)
3 users (show)

See Also:
Web browser: Firefox
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Description Michael M. 2012-02-17 09:29:03 UTC
On Special:Preferences all sections except the current should be hidden via Javascript. This seems to be broken with 1.19.
I tested with Firefox 3.6.x on mw: and simple: and all sections are visible, as if no Javascript was present. It works in debug mode (i.e. when appending ?debug=true to the URL), and it works on beta.wmflabs.
The Javascript is loaded (I get the file|ext.translate.selecttoinput|jquery.autoEllipsis%2CcheckboxShiftClick%2CclickTracking%2CcollapsibleTabs%2CdelayedBind%2ChighlightText%2Cjson%2CmakeCollapsible%2Cmw-jump%2Cplaceholder%2Csuggestions%2CtabIndex||mediawiki.api%2Chtmlform%2Cuser||mediawiki.legacy.mwsuggest||mediawiki.special.preferences&skin=vector&version=20120217T090945Z&*|ext.translate.selecttoinput|jquery.autoEllipsis%2CcheckboxShiftClick%2CclickTracking%2CcollapsibleTabs%2CdelayedBind%2ChighlightText%2Cjson%2CmakeCollapsible%2Cmw-jump%2Cplaceholder%2Csuggestions%2CtabIndex||mediawiki.api%2Chtmlform%2Cuser||mediawiki.legacy.mwsuggest||mediawiki.special.preferences&skin=vector&version=20120217T090945Z&*, with the code that should hide the sections) but apparently isn't executed. There are no errors in the Javascript error log. Clearing the cache doesn't help.
Comment 1 Sam Reed (reedy) 2012-02-17 14:42:01 UTC
Seeems fine on Chrome 19 and FF 10

You do see a flash of it incorrectly formatted before the JS etc is loaded in..

You've also pasted the urls without any (enough?) whitespace between them. So it looks like one REALLY long url ;)
Comment 2 Chris McMahon 2012-02-17 22:41:16 UTC
I checked FF 9 and IE7 and Special:Preferences looked fine in both.  

I did notice that the tabs other than "User profile" take a moment to load, but otherwise was fine.
Comment 3 Ryan Kaldari 2012-02-17 23:00:20 UTC
I confirmed the bug in Firefox 3.6.16. Works with debug=true and in newer versions of Firefox.
Comment 4 Ryan Kaldari 2012-02-17 23:04:57 UTC
Seems to be a race condition. If I do a hard reload with debug=true it renders correctly. But if I do a soft reload with debug=true it renders incorrectly.
Comment 5 Ryan Kaldari 2012-02-17 23:09:52 UTC
The ResourceLoader module involved is mediawiki.special.preferences which is defined in resources/Resources.php. This module loads resources/mediawiki.special/mediawiki.special.preferences.js with no dependencies declared.
Comment 6 Ryan Kaldari 2012-02-18 00:12:37 UTC
Hopefully fixed in r111802. Unfortunately, I can't reproduce the race condition in my local MediaWiki install (in Firefox 3), so we won't know for sure if this fixes it until it is deployed to
Comment 7 Ryan Kaldari 2012-02-18 01:42:22 UTC
Confirmed fixed on in Firefox 3.6.16.

Note You need to log in before you can comment on or make changes to this bug.