Last modified: 2010-05-15 15:38:20 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T5407, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 3407 - Encode subjects in page change notification emails


Summary:	Encode subjects in page change notification emails

Status:	RESOLVED FIXED

Product:	MediaWiki
Classification:	Unclassified
Component:	General/Unknown (Other open bugs)
Version:	1.5.x
Hardware:	All All

Importance:	Normal normal with 2 votes (vote)
Target Milestone:	---
Assigned To:	Nobody - You can work on this!

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2005-09-09 16:41 UTC by A.A. Shimono aka. himorin
Modified:	2010-05-15 15:38 UTC (History)
CC List:	0 users

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Patch for HEAD (8.68 KB, patch) 2005-12-12 06:04 UTC, Brion Vibber	Details
Add an attachment (proposed patch, testcase, etc.)

Description A.A. Shimono aka. himorin 2005-09-09 16:41:48 UTC

# from https://bugzilla.mozilla.org/show_bug.cgi?id=307731
subject of mail notification from MW 1.5rc4 is not encoded when using 2-byte
UTF-8 charactors (like Japanese).
it should be encoded by B-encode for mail header.

# or some special settings in MW to do this :p
# if so, it should be enable by default.

Comment 1 A.A. Shimono aka. himorin 2005-09-09 17:06:08 UTC

in include/UserMailer.php, we should add wfQuotedPrintable(), i think.

% diff UserMailer.php mediawiki-1.5rc4/includes/UserMailer.php 
327c327
<               $this->subject = wfQuotedPrintable( $subject );
---
>               $this->subject = $subject;

Comment 2 Pavel Zavyalov 2005-11-29 14:56:16 UTC

Russian wikipedia is also affected by this bug.
Please, fix it.

Comment 3 Rob Church 2005-11-29 16:06:04 UTC

(In reply to comment #2)
> Russian wikipedia is also affected by this bug.
> Please, fix it.

As are all the other Wikipedias, and any other wiki using MediaWiki. Just bear
with us while someone proposes a patch, reviews and commits it.

The version is set to 1.5rc4. Has this been fixed in a release version, like 1.5.2?

Comment 4 Brion Vibber 2005-12-12 06:04:26 UTC

Created attachment 1175 [details]
Patch for HEAD

* (bug 3407) Fix encoding of subject and from/to headers on notification
  mails; userMailer() now takes a MailAddress wrapper object instead of
  a raw string to abstract things a level.

Comment 5 Brion Vibber 2005-12-12 06:10:07 UTC

Applied to CVS HEAD.

Note You need to log in before you can comment on or make changes to this bug.

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links