Last modified: 2012-05-03 02:42:44 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T35992, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 33992 - Allow anon a formless purge with POST
Allow anon a formless purge with POST
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
General/Unknown (Other open bugs)
1.20.x
All All
: High normal (vote)
: 1.19.0 release
Assigned To: Aaron Schulz
: need-integration-test
Depends on:
Blocks: 31217
  Show dependency tree / graph
 
Reported: 2012-01-27 16:11 UTC by Umherirrender
Modified: 2012-05-03 02:42 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Umherirrender 2012-01-27 16:11:07 UTC 
Under 1.17 was it possible for anon to do a purge as POST without getting a form.

It is possible to get this back? The API allows this.

The 1.17 code has a $wgRequest->wasPosted() [1], but that is lost under 1.18 and only the user right 'purge' is used to make the difference [2].

Thanks.

[1] https://svn.wikimedia.org/viewvc/mediawiki/branches/wmf/1.17wmf1/includes/Article.php?view=markup#l1642
[2] https://svn.wikimedia.org/viewvc/mediawiki/branches/wmf/1.18wmf1/includes/actions/PurgeAction.php?view=markup#l63
Comment 1 Mark A. Hershberger 2012-01-30 18:09:32 UTC 
marking as deployment blocker since this is apparently a regression that was in 1.18.  Also, need a test for this if it is fixed to keep it from happening again.
Comment 2 Rob Lanphier 2012-01-30 22:57:15 UTC 
Aaron has an idea for how to fix this.  Seems to have been introduced with r86041
Comment 3 Aaron Schulz 2012-01-30 23:44:50 UTC 
Fixed in r110342.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links