Last modified: 2012-05-03 02:45:56 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 33931 - Missing dependency to mw.user
Missing dependency to mw.user
Product: MediaWiki extensions
Classification: Unclassified
CentralNotice (Other open bugs)
All All
: High major (vote)
: MW 1.19 version
Assigned To: Ryan Kaldari
: patch, patch-reviewed
Depends on:
Blocks: 31217
  Show dependency treegraph
Reported: 2012-01-24 18:51 UTC by Rainer Rillke @commons.wikimedia
Modified: 2012-05-03 02:45 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Add a dependency to /mediawiki/trunk/extensions/CentralNotice/special/SpecialBannerController.php (2.75 KB, patch)
2012-01-24 18:54 UTC, Rainer Rillke @commons.wikimedia

Description Rainer Rillke @commons.wikimedia 2012-01-24 18:51:29 UTC
In MW 1.19 it fails under some circumstances due to a not-declarded dependency to mw.user.anonymous(). Patch follows.
Comment 1 Rainer Rillke @commons.wikimedia 2012-01-24 18:54:42 UTC
Created attachment 9902 [details]
Add a dependency to /mediawiki/trunk/extensions/CentralNotice/special/SpecialBannerController.php

Add a dependency to /mediawiki/trunk/extensions/CentralNotice/special/SpecialBannerController.php

I think that's the most fast solution: Until the callback, other gadgets might have loaded the mw.user module and further deferring the XHR by waiting for mw.user might not be the best.

Evaluate yourself.
Comment 2 Ryan Kaldari 2012-01-25 01:07:26 UTC
Fixed in r109977. Thanks for the patch!

Note You need to log in before you can comment on or make changes to this bug.