Last modified: 2013-07-06 15:19:50 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T35903, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 33903 - jQuery tablesorter tests intermittent failure
jQuery tablesorter tests intermittent failure
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
ResourceLoader (Other open bugs)
1.20.x
All All
: Low normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-01-23 13:14 UTC by Niklas Laxström
Modified: 2013-07-06 15:19 UTC (History)
9 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Niklas Laxström 2012-01-23 13:14:05 UTC
All of the tablesorter tests (except the first one) fail on http://translatewiki.net/sw/Special:JavaScriptTest/qunit?uselang=he , but only when I (soft|hard)-refresh the page, and not even then always. They all have the same error:

Died on test #1: Object #<HTMLTableElement> has no method 'find' - {}

This seems to indicate missing dependencies, but isn't find() a jQuery method?
Comment 1 Siebrand Mazeland 2012-01-23 13:17:58 UTC
Added roan to CC because of this tweet: http://twitter.com/#!/catrope/status/160903306787561472: Apparently if you reassign jQuery.makeArray in IE for mobile, .find() is removed from jQuery #wtf
Comment 2 Niklas Laxström 2012-01-23 14:29:47 UTC
On similar note, the collapsible sidebar on twn has started acting up for me. Often it is fully collapsed or fully closed (which means the code runs), but there is no error of any kind in the log.
Comment 3 Antoine "hashar" Musso (WMF) 2012-01-23 22:43:59 UTC
I can't reproduce the issue with Firefox / Safari under Mac OS X. Neither on twn.net nor on my local repo.

Could it be a corrupted JQuery version in your cache?
Comment 4 Antoine "hashar" Musso (WMF) 2012-01-30 17:39:24 UTC
Niklas do you still have this issue on twn.net ?
Comment 5 Niklas Laxström 2012-01-30 18:27:09 UTC
Yes I do.
Comment 6 Nemo 2012-01-30 19:08:09 UTC
Couldn't reproduce on Firefox, but I reproduced it on Chromium 15.0.874.106.
When I first opened the link, I had some webfonts error and nothing else: r3q89UXgf7ZS9RKKF1h2MQ">http://p.defau.lt/?r3q89UXgf7ZS9RKKF1h2MQ ; on hard refresh, I had what described by Niklas.
I further refreshed the page and didn't get any error; opened it in another tab and got neither webfonts error nor tablesort errors on refresh; repeated the test in a new incognito window and reproduced the problem, then again on second refresh, then nothing on third.
Comment 7 Nemo 2012-01-30 19:10:42 UTC
Ehm, link is r3q89UXgf7ZS9RKKF1h2MQ">http://p.defau.lt/?r3q89UXgf7ZS9RKKF1h2MQ
https://translatewiki.net/sw/Special:JavaScriptTest/qunit?uselang=it fails too, but with different error http://p.defau.lt/?1lsZwtQEG9c1n1g_rFq6eg (bug 27721?).
Comment 8 Antoine "hashar" Musso (WMF) 2012-02-01 13:10:31 UTC
Nemo_bis : you are referencing entirely different issues which are linked to tablesorter tests not being language aware.
This bug is about Chromium outputting : Died on test #1: Object #<HTMLTableElement> has no method 'find' - {}
Comment 9 Antoine "hashar" Musso (WMF) 2012-02-01 13:13:28 UTC
Niklas:

Is this happening in different browsers?
Can you find out which revision introduced this issue?
You could also try out with a previous jQuery version by replacing the resource/jquery/jquery.js
Comment 10 Nemo 2012-02-01 13:16:34 UTC
(In reply to comment #8)
> Nemo_bis : you are referencing entirely different issues which are linked to
> tablesorter tests not being language aware.

Sorry? In comment 6 I said that I see exactly what Niklas sees. Yes, comment 7 is another bug.
Comment 11 Antoine "hashar" Musso (WMF) 2012-02-01 13:58:56 UTC
According to Niklas on IRC this seems to happen with $wgResourceLoaderExperimentalAsyncLoading = true

Changing component to Resource Loader and resetting assignee to default.
Comment 12 Niklas Laxström 2012-02-01 14:54:38 UTC
Setting wgResourceLoaderExperimentalAsyncLoading back to false seems to remove most of these issues. I have not been able to debug what is going on, since some random tests fail for no apparent reason, and there are no errors in error console. It's probably related to stuck sidebar menus I've been seeing on translatewiki.net.
Comment 13 Roan Kattouw 2012-02-18 10:34:40 UTC
My guess as to the probable cause: tablesorter isn't aliasing $ properly, some local script has redefined $ as a getElementByID() wrapper, and magic $ aliasing doesn't work anymore because it was deliberately (and IMO wrongly) removed in r111378.
Comment 14 Roan Kattouw 2012-02-18 10:36:52 UTC
(In reply to comment #13)
> My guess as to the probable cause: tablesorter isn't aliasing $ properly,
The tablesorter was, but the tests file wasn't. Does r111818 help?
Comment 15 Krinkle 2012-02-18 23:52:52 UTC
I heard some chatter the other day about Mobile not loading jQuery but Zepto (a mostly jQuery-compatible alternative). Could this be related ?
Comment 16 Derk-Jan Hartman 2013-07-06 15:19:50 UTC
I haven't heard reports about this anymore, so I think Roan's change fixed the problem. 

@Niklas, if you still see the problem, please do re open.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links