Last modified: 2012-05-03 02:45:57 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
First Last Prev Next    This bug is not in your last search results.
Bug 33873 - Proofread extension JS loading fully broken on 1.19
Proofread extension JS loading fully broken on 1.19
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
ProofreadPage (Other open bugs)
unspecified
All All
: High blocker (vote)
: MW 1.19 version
Assigned To: Nobody - You can work on this!
http://en.wikisource.beta.wmflabs.org...
: javascript
Depends on:
Blocks: 31217
  Show dependency tree / graph
 
Reported: 2012-01-22 05:22 UTC by Derk-Jan Hartman
Modified: 2012-05-03 02:45 UTC (History)
7 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
add wikibits as a dependency of ProofreadPage extension (447 bytes, patch)
2012-02-02 21:55 UTC, Zaran 		Details
Add an attachment (proposed patch, testcase, etc.)

Description Derk-Jan Hartman 2012-01-22 05:22:52 UTC 
The JS of wikisource is not including the right dependencies to work icw with 1.19 deploy it seems
Comment 1 Derk-Jan Hartman 2012-01-22 22:53:37 UTC 
dependency in proofread, to force loading of wikibits in debug mode (due to async bug in debug mode that Krinkle pointed out to Catrope). With that, we might be able to figure out why it's not working in production, since no console errors are shown.
Comment 2 Mark A. Hershberger 2012-01-25 19:30:41 UTC 
I think this is included now, right?
Comment 3 Mark A. Hershberger 2012-01-30 19:25:44 UTC 
Zaran, could you look at this?
Comment 4 Zaran 2012-01-30 20:10:34 UTC 
yes, I'm going to take a look at it some time this week. As Derk-Jan pointed out, it is only a problem of wikibits dependency, and the time at which it is loaded. It seems to work on the lab server by adding wikibits as a dependency of the ProofreadPage extension (it is currently not the case in the code in the SVN repository).
Comment 5 Mark A. Hershberger 2012-02-01 15:18:37 UTC 
(In reply to comment #4)
> yes, I'm going to take a look at it some time this week

Are you on IRC?  Could you ping me (hexmode on #mediawiki) if you start to work on this?
Comment 6 Zaran 2012-02-02 21:55:40 UTC 
Created attachment 9951 [details]
add wikibits as a dependency of ProofreadPage extension
Comment 7 Zaran 2012-02-02 21:58:18 UTC 
Yes I'm on IRC (Zaran on #mediawiki). I've started working on it yesterday.
There are two ways to solve the problem :
* set $wgIncludeLegacyJavascript = true in the config
* add mediawiki.legacy.wikibits as a dependency of the extension (see patch
above).

I don't know if the option $wgIncludeLegacyJavascript is planned to be set to
true on the deployment servers. But in all cases, it's probably better to add
the dependency to wikibits, because the current javascript code of the
extension relies on some deprecated functions (hookEvent for example).
Comment 8 Ryan Kaldari 2012-02-04 00:34:27 UTC 
Patch was applied, but apparently it's still not working on labs. I also committed r110691, but this didn't seem to fix it on labs either.
Comment 9 Sumana Harihareswara 2012-02-06 21:26:47 UTC 
By Feb 10th Mark is going to get someone to agree to fix this.
Comment 10 Roan Kattouw 2012-02-08 16:53:26 UTC 
http://en.wikisource.beta.wmflabs.org/wiki/Page:Wind_in_the_Willows_%281913%29.djvu/28 works for me now in the sense that I don't get any JS errors when I view it; I'm not familiar with ProofreadPage so maybe there are missing features I'm not aware of?

Is this still broken, and if so, how do I reproduce?
Comment 11 Zaran 2012-02-08 17:29:27 UTC 
It is still broken: in the proofreadpage extension, you're supposed to see the image of the page on the right side of the text.

See for example on fr.wikisource: http://fr.wikisource.org/wiki/Page:Leblanc_-_L’Île_aux_trente_cercueils.djvu/8
or on the wikisource instance on labs: http://wikisource-dev.wmflabs.org/w/index.php/Page:Bloy_-_Sueur_de_sang.djvu/227

Note that currently the bug doesn't show up when you test locally or on the wikisource instance on labs. But on the deployment instance, the proofreadpage specific javascript simply doesn't load without any error.

Note also that with &debug=true the bug disappears. But looking at the compressed javascript with &debug=false, it looks like the javascript of the extension is not even included.
Comment 12 Roan Kattouw 2012-02-08 19:22:44 UTC 
Fixed in r110949
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links