Last modified: 2012-04-18 18:25:38 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T35697, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 33697 - i18n issues with ArticleFeedbackv5
i18n issues with ArticleFeedbackv5
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
ArticleFeedbackv5 (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
: i18n
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2012-01-13 08:24 UTC by Siebrand Mazeland
Modified: 2012-04-18 18:25 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Siebrand Mazeland 2012-01-13 08:24:01 UTC 
See ArticleFeedbackv5.i18n.php:

	'articlefeedbackv5-special-showing' => '$1 feedback posts on this page', // FIXME: Needs plural support on $1.

	'articlefeedbackv5-bucket5-report-ratings' => '$1 ratings', // FIXME: Needs plural support for $1.

The current implementation inserts these strings into the page from PHP, and then replaces the numbers using JavaScript. That's a bug i18n issue.

So two changes required:
* Move whole string processing to JS
* Add plural support
Comment 1 Siebrand Mazeland 2012-04-18 18:23:50 UTC 
When code is updated because of a bug report,it is custom to add a link to whe
Comment 2 Siebrand Mazeland 2012-04-18 18:25:38 UTC 
Oops, dang touch screens.

When code is updated because of a bug report,it is custom to add a link to where the issues was resolved. Would you mind adding that, please?
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links