Last modified: 2012-02-24 02:52:14 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T35675, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 33675 - Use ShareKit to implement service sharing of links in iOS PhoneGap app
Use ShareKit to implement service sharing of links in iOS PhoneGap app
Status: RESOLVED FIXED
Product: Wikipedia App
Classification: Unclassified
Generic (Other open bugs)
1.0.0 (Android)
All All
: Low normal
: ---
Assigned To: Brion Vibber
https://github.com/phonegap/phonegap-...
:
Depends on:
Blocks: 33673
  Show dependency treegraph
 
Reported: 2012-01-12 00:02 UTC by Brion Vibber
Modified: 2012-02-24 02:52 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: iOS
Assignee Huggle Beta Tester: ---


Attachments

Description Brion Vibber 2012-01-12 00:02:36 UTC

    
Comment 2 Derk-Jan Hartman 2012-01-24 19:18:12 UTC
Initial work:
https://github.com/wikimedia/WikipediaMobile/pull/119

Other work that is needed:
Creating Twitter/Facebook etc API keys.
Create a system to add the keys without publishing them in git.... (vandalism sensitive)
Configure a bit the visual components of the share window, which is possible.

Add ShareKit to translatewiki, so that we can easily expand on it's included languages (will need some communication with ShareKit team.
https://github.com/ShareKit/ShareKit/tree/master/Classes/ShareKit/ShareKit.bundle

Add an identi.ca plugin to ShareKit
Comment 3 Brion Vibber 2012-01-26 01:05:54 UTC
I can't get this to merge to current trunk; when I try manually I end up screwing up the build somehow.

By itself I can build this branch (if I do 'git submodule init', 'git submodule update' for both the main repo *and* the ShareKit repo), but the 'Share' dialog's 'More' option shows only an empty sheet with 'Cancel' and 'Edit' buttons; 'Edit' toggles to 'Done' but never shows anything editable.
Comment 4 Brion Vibber 2012-01-26 01:34:19 UTC
Got it provisionally merged in https://github.com/wikimedia/WikipediaMobile/commit/e7c8d1cdf4b74d9b30bb777e07c409c4aee5e0d8


The above issue with the 'more' dialog remains.

I tried adding an API key for 'Read it later' (provisionally 4d7T9V8bg636el5818dn2a3u41ptb8c1) to the SHKConfig.h file, however since it's in a submodule I'm not sure how we can check in changes to it... it doesn't seem to work for me either; it still claims it needs an API key added when I try to share via Read it later.
Comment 5 Brion Vibber 2012-01-26 18:33:15 UTC
We got the readitlater API key working with the WMSHKConfigurator class, which is the proper way to do this. Will fill in more API keys in add'l bugs if needed...

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links