Last modified: 2012-04-20 12:41:27 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T35641, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 33641 - drop $wgUseSiteJs global
drop $wgUseSiteJs global
Status: RESOLVED WONTFIX
Product: MediaWiki
Classification: Unclassified
General/Unknown (Other open bugs)
1.20.x
All All
: Normal enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks: global-vars
  Show dependency tree / graph
 
Reported: 2012-01-10 16:41 UTC by Antoine "hashar" Musso (WMF)
Modified: 2012-04-20 12:41 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Antoine "hashar" Musso (WMF) 2012-01-10 16:41:35 UTC 
$wgUseSiteJs was added by r6223. The idea was to avoid an extra web server HIT.

One usage removed with r107777. There is only one left in OutputPage to add the 'site' resource loader link.

I think we could drop that global just like we dropped $wgUseSiteCss.
Comment 1 Brion Vibber 2012-01-10 20:49:02 UTC 
In the ResourceLoader world I don't think it actually adds a hit either, necessarily...
Comment 2 Krinkle 2012-01-10 20:54:29 UTC 
Indeed. Last I checked ResourceLoader doesn't output links for user/site js/css if the related pages on-wiki are empty or inexistent.

They could still serve as a way to prevent wiki-admins from writing JavaScript that is loaded on all pages for all users though, which I think is a valid use case that some mediawiki runners may wish to keep that way.
Comment 3 Antoine "hashar" Musso (WMF) 2012-04-20 12:41:27 UTC 
Marking wontfix per Krinkle comment #2
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links