Last modified: 2012-05-03 02:42:39 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T35583, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 33583 - Search namespaces from [[Special:Preferences]] are ignored
Search namespaces from [[Special:Preferences]] are ignored
Product: MediaWiki
Classification: Unclassified
Special pages (Other open bugs)
All All
: Normal normal (vote)
: 1.19.0 release
Assigned To: Antoine "hashar" Musso (WMF)
: patch, patch-need-review
Depends on:
Blocks: 31217
  Show dependency treegraph
Reported: 2012-01-07 17:13 UTC by Rainer Rillke @commons.wikimedia
Modified: 2012-05-03 02:42 UTC (History)
8 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Patch to take into account the user's namespaces pref (1.17 KB, patch)
2012-01-10 21:05 UTC, Brad Jorsch

Description Rainer Rillke @commons.wikimedia 2012-01-07 17:13:34 UTC
Using this component (may be wrong) because I was advised that WMF is not utilize MWs internal search engine.

When clicking on the magnifying glass in the search box, the preferences I've set in [[Special:Preferences]] are ignored and search is done for "content pages" instead of advanced with my settings.

This is probably caused by fixing Bug 33270 and Bug 32228.
Comment 1 Bawolff (Brian Wolff) 2012-01-07 17:19:47 UTC
Can reproduce on 1.19 (but not stock 1.18.0) without lucene, so presumably something in core mediawiki search stuff that was backported to wmf.
Comment 2 Bawolff (Brian Wolff) 2012-01-07 17:24:44 UTC
Appears to be caused by r106780
Comment 3 Antoine "hashar" Musso (WMF) 2012-01-09 11:41:54 UTC
I have added a test case with r108400 albeit commented out.
Comment 4 Antoine "hashar" Musso (WMF) 2012-01-09 11:51:29 UTC
This bug is also on production wiki since r106780 was merged by r107975.

Confirmed on
* set your namespace searching option to (Main)
* in the top right input box search for "foobar"
* Search page show pages from Manual and Extension namespaces.
Comment 5 Brad Jorsch 2012-01-10 21:05:27 UTC
Created attachment 9835 [details]
Patch to take into account the user's namespaces pref

I changed the component to "Special pages" to match bug 33270.

The problem is that the "fix" for bug 33270 assumed that if no namespaces were explicitly given in the HTTP request then the "default" search was wanted, while only the advanced option uses the user preference. One simple fix is to just not assume any profile (the old behavior) if the user has specified any search namespaces in their preferences.
Comment 6 Mark A. Hershberger 2012-01-11 16:48:45 UTC
hashar, Could you look at this patch and apply it?
Comment 7 Antoine "hashar" Musso (WMF) 2012-01-12 09:04:28 UTC
I have applied it with r108712 and uncommented the related test from r108400.

Thanks a lot Brad.
Comment 8 Antoine "hashar" Musso (WMF) 2012-01-12 21:37:04 UTC
Applied live with r108751 . Would be great if someone can verify it :-)
Comment 9 Derk-Jan Hartman 2012-01-12 22:32:43 UTC
Verified working now.

Note You need to log in before you can comment on or make changes to this bug.