Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T35471, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 33471 - $wgCookieSecure = 'detect' fails when $wgServer is protocol-relative

Summary:	$wgCookieSecure = 'detect' fails when $wgServer is protocol-relative

Status: RESOLVED FIXED Product: MediaWiki Classification: Unclassified Component: General/Unknown (Other open bugs) Version: unspecified Hardware: All All Importance: Normal normal (vote) Target Milestone: 1.20.0 release Assigned To: Nobody - You can work on this! URL: Whiteboard: Keywords: Depends on: Blocks: 20342   Show dependency tree / graph		Reported: 2012-01-02 14:31 UTC by Chad H. Modified: 2012-09-27 01:06 UTC (History) CC List: 5 users (show) csteipp krinklemail mah matanya tylerromeo See Also: Web browser: --- Mobile Platform: --- Assignee Huggle Beta Tester: ---

Attachments Add an attachment (proposed patch, testcase, etc.)

Description Chad H. 2012-01-02 14:31:06 UTC Snippet from Setup: if ( $wgCookieSecure === 'detect' ) { $wgCookieSecure = ( substr( $wgServer, 0, 6 ) === 'https:' ); } Should probably use WebRequest::detectProtocol() instead. Comment 1 Tyler Romeo 2012-08-10 20:31:20 UTC https://gerrit.wikimedia.org/r/18627 Comment 2 Chris Steipp 2012-09-27 00:17:58 UTC WebRequest::detectProtocol() returns the string 'https' (without a colon).