Last modified: 2012-07-24 02:39:53 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T35225, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 33225 - VisualEditor: Undo of indentation is not properly displayed
VisualEditor: Undo of indentation is not properly displayed
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
Data Model (Other open bugs)
unspecified
PC Windows 7
: Normal normal
: VE-deploy-2012-07-23
Assigned To: Roan Kattouw
:
Depends on:
Blocks: 37854
  Show dependency treegraph
 
Reported: 2011-12-17 20:12 UTC by david.hellfeuer
Modified: 2012-07-24 02:39 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description david.hellfeuer 2011-12-17 20:12:20 UTC
Hi,

in the Visual Editor Sandbox, when you indent and then undo, the WYSIWG display doesn't show the indentation undone.

More precisely:
1) I write some free text in a text only paragraph
2) then indent items of an existing list outside the text paragraph using the indentation button
3) then I hit undo

What I expect: The indentation is undone.
What happens instead:
a) The text is removed (i.e. the second but last action is undone)
b) but the indentation remains.
c) More undo clicks will just go on undoing actions before the indentation.

After going a few times back and forth using the undo and redo buttons, the editor seems completely messed up:
d) I cannot add further new lines at the end of the page
e) The blinking cursor lags by one character (i.e. when I type "david", the cursor will be between i and d)
f) Eventually, the characters I type are no longer displayed, though the blinking cursor moves when I type (even advances from line to line without me pressing enter)

Speculation: When I show the preview view after step 3), the indentation has correctly been undone there (in addition to other actions having been undone). So maybe this is a bug only in the display part, since the code is apparently correctly changed.

Best,
David
Comment 1 James Forrester 2012-06-22 20:54:34 UTC
Assuming that this will work when we have indenting again. :-)
Comment 2 James Forrester 2012-06-22 22:05:38 UTC
Mass-moving items into VisualEditor product
Comment 3 James Forrester 2012-06-23 01:34:03 UTC
Mass-move out of "General" to "Data Model".
Comment 4 James Forrester 2012-06-25 18:48:47 UTC
Almost certainly will work once we've got to the point of nested lists working again.
Comment 5 James Forrester 2012-07-02 21:56:17 UTC
Add to "VE-deploy-2012-07-09" milestone per this morning's meeting.
Comment 6 Roan Kattouw 2012-07-24 02:39:53 UTC
Fixed in today's deployment.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links