Last modified: 2011-12-14 05:13:33 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T35010, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 33010 - External links using {{fullurl:}} are saved twice into externallinks table
External links using {{fullurl:}} are saved twice into externallinks table
Status: NEW
Product: MediaWiki
Classification: Unclassified
Parser (Other open bugs)
1.18.x
All All
: Normal major (vote)
: ---
Assigned To: Nobody - You can work on this!
: need-parsertest, parser
Depends on:
Blocks: 20342
  Show dependency treegraph
 
Reported: 2011-12-12 23:15 UTC by Danny B.
Modified: 2011-12-14 05:13 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Danny B. 2011-12-12 23:15:04 UTC
When saving a page with new external link in form of e.g.:

 [{{fullurl:tools:~danny_b|foo=bar}} My tools]

given link is saved twice in externallinks table.
Comment 1 p858snake 2011-12-12 23:17:28 UTC
I believe its designed this way for protocol-relative urls, so both http:// and https:// exist in the table.
Comment 2 Roan Kattouw 2011-12-13 00:06:44 UTC
(In reply to comment #1)
> I believe its designed this way for protocol-relative urls, so both http:// and
> https:// exist in the table.
That's exactly right.
Comment 3 p858snake 2011-12-13 00:41:34 UTC
(add a note from irc about the four times thing)

> [10:05] <p858snake|l> Danny_B|backup: I believe its needed for our protocol relative urls we use now, RoanKattouw will probably know more (if hes around at this hour)
> [10:10] <Danny_B|backup> p858snake|l: well, the other thing is, that some are stored even 4 times
> [10:11] <p858snake|l> you might want to add that to the bug with some examples
Comment 4 Danny B. 2011-12-13 00:49:48 UTC
(In reply to comment #2)
> (In reply to comment #1)
> > I believe its designed this way for protocol-relative urls, so both http:// and
> > https:// exist in the table.
> That's exactly right.

However, two _same_ protocol relative links are stored.

So no for instance:
http://toolserver.org/~danny_b?foo=bar
https://toolserver.org/~danny_b?foo=bar

but twice
//toolserver.org/~danny_b?foo=bar
Comment 5 Danny B. 2011-12-13 00:58:50 UTC
Ah, el_index is different, OK, I was checking el_to.

However problem described in comment 3 still applies. - Some URLs are stored 4 times (-> twice a pair of http/https).

I haven't find any dependency on any particular action yet though.
Comment 6 Mark A. Hershberger 2011-12-14 05:11:12 UTC
is this related to Bug 32951?

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links