Last modified: 2014-09-12 22:13:30 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T34890, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 32890 - Make UploadWizard work crossdomain


Summary:	Make UploadWizard work crossdomain

Status:	REOPENED

Product:	MediaWiki extensions
Classification:	Unclassified
Component:	UploadWizard (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	Normal normal (vote)
Target Milestone:	---
Assigned To:	Nobody - You can work on this!

URL:
Whiteboard:
Keywords:

Duplicates:	27314 (view as bug list)
Depends on:
Blocks:	27313
	Show dependency tree / graph

Reported:	2011-12-09 04:55 UTC by Neil Kandalgaonkar
Modified:	2014-09-12 22:13 UTC (History)
CC List:	10 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Neil Kandalgaonkar 2011-12-09 04:55:19 UTC

This code is dead and has been sitting in a useless file for a while. Recording it here. Simply changes the type of request to jQuery-specific JSONP.

			

// If cross domain setup a callback: 
			if( ! mw.isLocalDomain( url ) ) {				 
				if( url.indexOf( 'callback=' ) == -1 || parameters[ 'callback' ] == -1 ) {
					// jQuery specific jsonp format: ( second ? is replaced with the callback ) 
					url += ( url.indexOf('?') == -1 ) ? '?callback=?' : '&callback=?';
				}				 
			}

Comment 1 Derk-Jan Hartman 2011-12-09 22:00:35 UTC

doesn't cross domain require CORS support ? I never can remember which parts of our API/infra have that and which don't...

Comment 2 Neil Kandalgaonkar 2011-12-10 01:19:01 UTC

The idea here is to use JSONP to get around that.

Comment 3 Mark Holmquist 2012-06-01 22:07:04 UTC

*** Bug 27314 has been marked as a duplicate of this bug. ***

Comment 4 Mark Holmquist 2012-06-01 22:09:21 UTC

*** Bug 27314 has been marked as a duplicate of this bug. ***

Comment 5 Mark Holmquist 2012-06-01 23:20:05 UTC

I'm not sure how to test this, but it's implemented....I think you'd need to explicitly allow JSONP requests from the wiki with UW to the wiki with the API. Even then, I'm not entirely sure this would work.

See https://gerrit.wikimedia.org/r/9718

Comment 6 Mark Holmquist 2012-08-14 16:21:25 UTC

Discussion in gerrit: It's pretty much *not* working. Standby.

Comment 7 Nischay Nahata 2013-05-21 08:22:44 UTC

I would like to work on this but don't really understand it yet. Can someone throw more light on this bug? or how to reproduce it?

Comment 8 Gerrit Notification Bot 2013-06-05 14:17:34 UTC

https://gerrit.wikimedia.org/r/9718 (Gerrit Change I47691bb8b12564fcc9f4451907b7d5838c44b8f2) | change ABANDONED [by MarkTraceur]

Comment 9 Fabrice Florin 2014-09-09 23:31:41 UTC

Hi guys, cross-wiki uploads is on the multimedia team's roadmap for next year:

https://www.mediawiki.org/wiki/UploadWizard

But it is a major undertaking, not something that a quick bug fix can handle. 

Marking this as won't fix for now. Thanks for your understanding.

Comment 10 matanya 2014-09-09 23:57:35 UTC

Per conversion with Fabrice:

it is still wanted, and intended to fix, just not now - hence, open, not won't fix.

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links