Last modified: 2013-10-23 18:17:39 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T34754, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 32754 - Blocked user trying to edit gets an error


Summary:	Blocked user trying to edit gets an error

Status:	RESOLVED FIXED

Product:	MediaWiki
Classification:	Unclassified
Component:	User blocking (Other open bugs)
Version:	1.18.x
Hardware:	All All

Importance:	Normal normal (vote)
Target Milestone:	1.18.x release
Assigned To:	Nobody - You can work on this!

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:	32711
	Show dependency tree / graph

Reported:	2011-12-01 19:13 UTC by Geoffrey De Belie
Modified:	2013-10-23 18:17 UTC (History)
CC List:	3 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Geoffrey De Belie 2011-12-01 19:13:59 UTC

It is fixed in trunk, but a patch is needed for 1.18

Blocked user trying to edit gets an error:
Fatal error: Call to undefined method WebRequest::getIP() in /home/u826247802/public_html/wiki/includes/User.php on line 2942

Comment 1 Rusty Burchfield 2011-12-01 19:43:03 UTC

A User.php change that uses a new WebRequest API (getIP) was backported to 1.18.  I asked Geoffrey to try copying the new WebRequest API over and a new error occurred.

A safer/simpler option I overlooked is to replace the new API call with "wfGetIP()".

This is not an issue in trunk (since the new API is there) but should be fixed in the 1.18 branch for the next point release.

Comment 2 Aaron Schulz 2011-12-02 21:49:53 UTC

Fixed in r105009.

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links