Last modified: 2013-10-23 18:17:04 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T34702, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 32702 - Skin::makeGlobalVariablesScript was removed between 1.17 and 1.18 but wasn't even marked as deprecated in 1.17
Skin::makeGlobalVariablesScript was removed between 1.17 and 1.18 but wasn't ...
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
General/Unknown (Other open bugs)
1.18.x
All All
: Normal normal (vote)
: 1.18.x release
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks: 32711
  Show dependency tree / graph
 
Reported: 2011-11-29 01:28 UTC by Sam Reed (reedy)
Modified: 2013-10-23 18:17 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Sam Reed (reedy) 2011-11-29 01:28:27 UTC 
Skin::makeGlobalVariablesScript was removed between 1.17 and 1.18 but wasn't even marked as deprecated in 1.17

And on that note, SkinTemplate still mentions Skin::makeGlobalVariablesScript... It doesn't exist in trunk!
Comment 1 Mark A. Hershberger 2011-12-02 21:23:35 UTC 
from triage, robla asks how hard this it is to restore back compat and says "if it's hard, then I think this becomes a documentation issue.  if it's easy, we should at least provide a patch, I think"
Comment 2 Litso 2011-12-18 15:53:08 UTC 
I'm still using a skin with plenty of modifications to the head element. How do I go about using the Skin::makeGlobalVariablesScript (or it's modern variant) without having to switch to using the "$useHeadElement = true" option?
Comment 3 Alexandre Emsenhuber [IAlex] 2011-12-29 20:40:08 UTC 
Readded in r107595.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links