Last modified: 2008-12-09 13:31:10 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T5270, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 3270 - mark as patrolled links in irc-rc (dutch wikipedia)
mark as patrolled links in irc-rc (dutch wikipedia)
Product: Wikimedia
Classification: Unclassified
General/Unknown (Other open bugs)
PC Windows XP
: Normal normal with 14 votes (vote)
: ---
Assigned To: Leon Planken
: patch
Depends on:
Blocks: 3741 16599
  Show dependency treegraph
Reported: 2005-08-25 18:07 UTC by henna
Modified: 2008-12-09 13:31 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

patched the bug; rcid is now sent over irc if appropriate (875 bytes, patch)
2005-10-28 12:48 UTC, Leon Planken
fixed patch; inserted ID is now only retrieved if it's used (1.28 KB, patch)
2005-11-03 11:24 UTC, Leon Planken
patch for reopened bug (534 bytes, patch)
2005-11-03 14:36 UTC, Leon Planken

Description henna 2005-08-25 18:07:43 UTC
nl.wikipedia uses the mark as patrolled system to protect against vandalism. The
links that are posted by rc in the irc recent changes interface are not able to
mark an article as patrolled. 

I have written a patch to solve this issue, I've uploaded it to my own website
Comment 1 henna 2005-08-25 21:18:36 UTC
ok, some background information :)
nl.wp uses the mark as patrolled system, wich worked quite well till
Vandalfigher came around. The main problem is that people who use vandal fighter
are unable to mark an edit as patrolled, causing other people to check that edit
at a later time. When they see the edit already taken care off and this
happening time and time again they get upset, to the point of people giving up
on checking edits for vandalism completely. 

The easiest solution in my eyes is to support the mark as patrolled system by
ensuring that links postend to the irc contained the rcid. I introduced a config
variable for giving people the choice to either work with the mark as patrolled
system or not, and I changed the url's transmitted to the irc program by adding
the rcid to them.
Comment 2 Ronald Beelaard 2005-09-18 00:18:36 UTC
In my opinion, it is not yet enough, but still necessary, to output 
the rcid to the irc output. CryptoDerk's Vandalfighter has 
subsequently to take this value as well and append the &rcid=<value> 
to the url by which an article is called up in the browser. I'll draw 
Cryptoderks attention to this "bug".
Comment 3 Georg Petry 2005-09-18 21:41:23 UTC
Did reassign the bug on question of cegmail. Do not chop of my head ;)
Comment 4 Nico Peelen 2005-09-18 23:36:01 UTC
Could you supply us with a copy of this question so that people watching this
bug actually have an idea why it has been reassigned?
Comment 5 Georg Petry 2005-09-20 05:49:40 UTC
[23:27] <Obarskyr> CE jap nu fix dan ook die bug als je hem assigned hebt ;)
[23:28] <CE> ja obarskyr, daar ben ik ook bang voor
[23:28] <CE> ik dacht dat het systeem heel anders werkte
[23:29] <CE> ik meende dat er eerste een aantal gebruikers accoord moet gaan met
de melding voordat ie wordt opgenomen (ASSIGNED)
[23:34] <CE> kan ik de status weer terugzetten op NEW zodat iemand anders ze kan
[23:34] <kim_register> CE, lijkt me wijs
[23:34] <kim_register> want die zou het wel eens kunnen
[23:34] <CE> kim, lijkt mij ook wijs, maar ik weet niet hoe dat te doen
[23:37] <Obarskyr> CE fixed , niets doen
[23:37] <CE> ok, heb jij het opgelost obarskyr?
[23:37] <Obarskyr> ik denk het
[23:38] <Obarskyr>

This is a part of the IRC log in question. I am not allowed to publish the whole
log, so this are only bits and pieces of the communication. I hope this will be
enough as 'proof' of my action. Basically it was a mistake of CE to assign it.
Comment 6 CE 2005-09-20 08:04:55 UTC
This was my first experience with bugzilla. It was my mistake to change NEW into ASSIGNED. On IRC I asked 
for help to get the status NEW again. Sorry for the inconvenience. I will try to be more careful in the 
future. Chris (CE)
Comment 7 Leon Planken 2005-10-28 12:39:08 UTC
I wrote a patch, loosely based on henna's, which seemed to have some problems...
you can find it here:
Comment 8 Leon Planken 2005-10-28 12:48:48 UTC
Created attachment 1031 [details]
patched the bug; rcid is now sent over irc if appropriate
Comment 9 Leon Planken 2005-11-03 11:24:04 UTC
Created attachment 1040 [details]
fixed patch; inserted ID is now only retrieved if it's used

fixed patch
Comment 10 Ævar Arnfjörð Bjarmason 2005-11-03 11:27:21 UTC
Comment 11 Leon Planken 2005-11-03 14:34:55 UTC
Bug reopened: rcid wasn't displayed for new pages yet
Comment 12 Leon Planken 2005-11-03 14:36:22 UTC
Created attachment 1041 [details]
patch for reopened bug

this patch also displays rcid for new pages

Note You need to log in before you can comment on or make changes to this bug.