Wikimedia Bugzilla is closed!

LU doesn't really have anything to do with this, Its how we handle our language files, LU just updates the languages files from SVN more often compared to someone  having to manually svn them up and push them out.

(In reply to comment #1)
> LU doesn't really have anything to do with this, Its how we handle our language
> files, LU just updates the languages files from SVN more often compared to
> someone  having to manually svn them up and push them out.

It's not a simple svn up. But in this case if we consider it as svn up for individual sites, the issue is, don't let it svn up extensions/ContactPage/ContactPage.i18n.php on dewiki.

(In reply to comment #2)
> (In reply to comment #1)
> > LU doesn't really have anything to do with this, Its how we handle our language
> > files, LU just updates the languages files from SVN more often compared to
> > someone  having to manually svn them up and push them out.
> 
> It's not a simple svn up. But in this case if we consider it as svn up for
> individual sites, the issue is, don't let it svn up
> extensions/ContactPage/ContactPage.i18n.php on dewiki.
The problem is, it's not separated per-wiki. All wikis share the same set of messages, so if ContactPage is installed on one wiki, its messages will be available on all wikis.

Does ContactPage override the contact message? If so, that's annoying. But a dewiki sysop can fix this issue easily by editing [[MediaWiki:Sidebar]].

(In reply to comment #3)
> Does ContactPage override the contact message? If so, that's annoying. But a
> dewiki sysop can fix this issue easily by editing [[MediaWiki:Sidebar]].

Override in what way? I guess it should behave as if 'contact' message exists in PHP files.

(In reply to comment #4)
> (In reply to comment #3)
> > Does ContactPage override the contact message? If so, that's annoying. But a
> > dewiki sysop can fix this issue easily by editing [[MediaWiki:Sidebar]].
> 
> Override in what way? I guess it should behave as if 'contact' message exists
> in PHP files.
I see two possible reasons why this bug could have occurred.

1: the German community used 'contact' in the sidebar and didn't know a message by that name was used by the software until LU came and changed it
2: the 'contact' thing is a message in MediaWiki core, and ContactPage is being annoying by redefining (overriding) the message in its extension i18n file

Which of these two is right? Or is it something else?

(In reply to comment #5)
> Which of these two is right? Or is it something else?

I believe this message was widely used among wikis(*) before LU and Extension:ContactPage (CP) came and have never been in MediaWiki core so it caused no problem until LU and CP came (and maybe no many people found this message has been introduced "secretly" into their wikis).

(*) I found this page on zhwiki initially and checked several wikis including enwiki, dewiki, jawiki, etc. and used dewiki to submit this bug because enwiki (as the default language) and zhwiki (with so complex fallback configuration) are too special, though I'm de-0.

(In reply to comment #6)
> (In reply to comment #5)
> > Which of these two is right? Or is it something else?
> 
> I believe this message was widely used among wikis(*) before LU and
> Extension:ContactPage (CP) came and have never been in MediaWiki core so it
> caused no problem until LU and CP came (and maybe no many people found this
> message has been introduced "secretly" into their wikis).
> 
OK, so in that case it's ContactPage's fault for hijacking a widely-used message.

Fixed in r104971. Will need to be backported and deployed before it's visible that it's fixed.

(In reply to comment #8)
> Fixed in r104971. Will need to be backported and deployed before it's visible
> that it's fixed.

After half a year the string "Contact page" is still in dewiki's sidebar.

Still valid.

(In reply to comment #10)
> Still valid.

Damn.

Investigating:
* de.wp's side bar is here: http://de.wikipedia.org/wiki/MediaWiki:Sidebar
* Sidebar says "Kontakt" and leads to http://de.wikipedia.org/wiki/Wikipedia:Kontakt. The message is http://de.wikipedia.org/wiki/MediaWiki:Contact per MediaWiki:Sidebar. All access anonymous, so uselang=de.
* For http://de.wikipedia.org/wiki/Wikipedia:Kontakt?uselang=en, "Contact page" is being shown. That's also expected, as http://de.wikipedia.org/wiki/MediaWiki:Contact/en (page doesn't exist), has content "Contact page" from the message cache.

It doesn't come from extension ContactPage, because that extension no longer has the i18n key "contact" -- even though the extension is not active on de.wp, AFIAK the localisation cache is shared across Wikimedia wikis, and de.wp has all the keys for all the extensions on the Wikimedia cluster (as do all other wikis).

The Wikimedia configuration also defines wgUseContactPageFundraiser in http://noc.wikimedia.org/conf/highlight.php?file=InitialiseSettings.php. That means that an extension called ContactPageFundraiser is also in the mix. Damn... I'll be submitting a fix for that one too...

Gerrit change #37779 should fix this when merged.

(In reply to comment #12)
> Gerrit change #37779 should fix this when merged.

Patch got abandoned.

Siebrand: Shall the bug assignee be reset to default, if you don't plan to work on this?

ContactPage has essentially been rewritten in https://gerrit.wikimedia.org/r/113879 and https://gerrit.wikimedia.org/r/113883

ContactPageFundraiser is a copy/paste hack. It should be moved to being a config item on the WMF cluster under ContactPage. Then the extension can be abandoned.

I did similar to what Siebrand did in https://gerrit.wikimedia.org/r/37779 myself in https://gerrit.wikimedia.org/r/110142. That can go away and die too.

Killing and disabling ContactPageFundraiser is in https://gerrit.wikimedia.org/r/#/c/110292/