Last modified: 2011-11-28 10:59:00 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T34662, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 32662 - apc.css should be loaded with ResourceLoader


Summary:	apc.css should be loaded with ResourceLoader

Status:	RESOLVED FIXED

Product:	MediaWiki extensions
Classification:	Unclassified
Component:	APC (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	Normal minor (vote)
Target Milestone:	---
Assigned To:	Lewis Cawte

URL:
Whiteboard:
Keywords:	patch, patch-reviewed

Depends on:
Blocks:	29713
	Show dependency tree / graph

Reported:	2011-11-26 19:36 UTC by Lewis Cawte
Modified:	2011-11-28 10:59 UTC (History)
CC List:	2 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add ResourceLoader support (738 bytes, patch) 2011-11-26 19:38 UTC, Lewis Cawte	Details
?debug=1 works (805 bytes, patch) 2011-11-26 20:02 UTC, Lewis Cawte	Details
Adds ResourceLoader support for apc.css (fix previous patch errors) (798 bytes, patch) 2011-11-26 20:12 UTC, Lewis Cawte	Details
Show Obsolete (2) Add an attachment (proposed patch, testcase, etc.)

Description Lewis Cawte 2011-11-26 19:36:55 UTC

Well, the title basicly tells the entire story. The apc.css file should be loaded with ResourceLoader.

Comment 1 Lewis Cawte 2011-11-26 19:38:46 UTC

Created attachment 9558 [details]
Add ResourceLoader support

Comment 2 Lewis Cawte 2011-11-26 19:58:12 UTC

Comment on attachment 9558 [details]
Add ResourceLoader support

>Index: APC.php
>===================================================================
>--- APC.php	(revision 104292)
>+++ APC.php	(working copy)
>@@ -32,3 +32,7 @@
> $wgSpecialPageGroups['APC'] = 'wiki';
> 
> $wgAvailableRights[] = 'apc';
>+
>+$wgResourceModules['ext.apc'] = array(
>+        'styles' => 'apc.css',
>+        'localBasePath' => dirname(__FILE__),
>+        'remoteExtPath' => 'APC'
>+);
>Index: SpecialAPC.php
>===================================================================
>--- SpecialAPC.php	(revision 104292)
>+++ SpecialAPC.php	(working copy)
>@@ -100,9 +100,7 @@
> 			}
> 		}
> 
>-		$wgOut->addLink( array( 'rel' => 'stylesheet', 'type' => 'text/css',
>-			'href' => "$wgScriptPath/extensions/APC/apc.css?$wgStyleVersion", )
>-		);
>+		$wgOut->addModuleStyles( 'ext.apc' );
> 
> 		$this->getLogo();
> 		$this->mainMenu();

Comment 3 Lewis Cawte 2011-11-26 20:02:26 UTC

Created attachment 9559 [details]
?debug=1 works

Comment 4 John Du Hart 2011-11-26 20:04:37 UTC

Comment on attachment 9559 [details]
?debug=1 works

+        'styles' => 'apc.css',

Spaces, otherwise I'll apply it.

Comment 5 Lewis Cawte 2011-11-26 20:12:44 UTC

Created attachment 9560 [details]
Adds ResourceLoader support for apc.css (fix previous patch errors)

Fix spacing.

Comment 6 John Du Hart 2011-11-26 20:19:33 UTC

r104297

Comment 7 Antoine "hashar" Musso (WMF) 2011-11-28 10:59:00 UTC

Well done Lewis! Thanks for the patch 8-)

Note You need to log in before you can comment on or make changes to this bug.

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links