Last modified: 2012-01-12 10:59:31 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T34508, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 32508 - Too many update messages even though nothing much happens
Too many update messages even though nothing much happens
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Database (Other open bugs)
1.20.x
All All
: Lowest enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks: 22753
  Show dependency treegraph
 
Reported: 2011-11-20 02:28 UTC by Dan Jacobson
Modified: 2012-01-12 10:59 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
update.php output still contains about 1/5 of the long message lines (8.11 KB, text/plain)
2011-11-22 16:11 UTC, Dan Jacobson
Details

Description Dan Jacobson 2011-11-20 02:28:26 UTC
How are we to read through these messages now that they have suddenly doubled in width?

Adding ar_deleted field to table archive......already have ar_deleted field in archive table, skipping new field patch.
Adding ipb_deleted field to table ipblocks......already have ipb_deleted field in ipblocks table, skipping new field patch.
Adding fa_deleted field to table filearchive......already have fa_deleted field in filearchive table, skipping new field patch.
Adding ar_len field to table archive......already have ar_len field in archive table, skipping new field patch.
Adding ipb_block_email field to table ipblocks......already have ipb_block_email field in ipblocks table, skipping new field patch.
Comment 1 Sam Reed (reedy) 2011-11-21 19:33:42 UTC
(In reply to comment #0)
> How are we to read through these messages now that they have suddenly doubled
> in width?

Use a wider console window
Comment 2 OverlordQ 2011-11-21 20:56:39 UTC
Instead of going from

... category table already exists

to

Creating category table... ...category table already exists. Skipping create table category

why not something that says the same thing and not be extremely wordy, like:

...category table already exists, not creating.
Comment 3 Platonides 2011-11-21 21:02:50 UTC
The "Creating category table..." is useful in case it died between the two ellipsis.

You usually don't need to read all of them (unless you want to), and there is a --quiet switch to only show errors.
Comment 4 Dan Jacobson 2011-11-21 21:07:42 UTC
In the past it was quite easy to see which ones changed something and which ones didn't. Not any more.
And one wants to see which ones changed something, along with errors.
Comment 5 Chad H. 2011-11-21 21:08:29 UTC
(In reply to comment #1)
> (In reply to comment #0)
> > How are we to read through these messages now that they have suddenly doubled
> > in width?
> 
> Use a wider console window

This is not a helpful suggestion.
Comment 6 Antoine "hashar" Musso (WMF) 2011-11-22 13:30:48 UTC
I have reverted change r103691 with  r103892.
update.php output is back :-)
Comment 7 Dan Jacobson 2011-11-22 16:11:21 UTC
Created attachment 9525 [details]
update.php output still contains about 1/5 of the long message lines

Thanks however about 1/5 of those long lines are still in the output.
Many of them clearly just need the part before the dots chopped in order to match the same style of meaning as the other lines. A few of course cannot just so simply be chopped and still make sense though.
Comment 8 Sam Reed (reedy) 2011-11-22 16:30:48 UTC
(In reply to comment #7)
> Created attachment 9525 [details]
> update.php output still contains about 1/5 of the long message lines
> 
> Thanks however about 1/5 of those long lines are still in the output.
> Many of them clearly just need the part before the dots chopped in order to
> match the same style of meaning as the other lines. A few of course cannot just
> so simply be chopped and still make sense though.

r103917 reverts a few more, but leaves some of the normalisation
Comment 9 Dan Jacobson 2011-12-01 23:55:31 UTC
Currently there are only two problem lines left,

...uploadstash table already exists.
...user_former_groups table already exists.
...config table already exists.
...type_action key already set on logging table.
Migrating remaining user_options... Beginning batch conversion of user options.
No user_options field in the user table. Nothing to migrate...done.
...user table does not contain user_options field.
...have rev_sha1 field in revision table.
...have ar_sha1 field in archive table.

that do nothing however stick out without dots.
Comment 10 Dan Jacobson 2011-12-02 00:19:03 UTC
Oh, and at the very bottom of each run I guess
Purging caches...done.
is always OK to leave not dot prefixed, but I'm not sure about
Checking site_stats row...done.
Comment 11 Antoine "hashar" Musso (WMF) 2011-12-08 10:05:36 UTC
I have cleaned the output for user_options migration with r105531.

Jidanni, can you please review the output? Thanks!
Comment 12 Dan Jacobson 2011-12-08 11:51:02 UTC
Looks good...

...ug_group field does not exist in user table, skipping modify field patch.
...have us_chunk_inx field in uploadstash table.
Purging caches...done.
Checking site_stats row...done.

Wait, those two lines added at the end.
"Checking" surely deserves dots.

Maybe each new item added needs a second programmer to make sure it
gets dotted.
Comment 13 Antoine "hashar" Musso (WMF) 2011-12-08 16:40:34 UTC
Those two last checks are not really database updates per see. I guess those can stay as they are.
Comment 14 Chad H. 2011-12-08 17:12:07 UTC
(In reply to comment #13)
> Those two last checks are not really database updates per see. I guess those
> can stay as they are.

The last one is, and should be fixed. The next to last one is not (and to be honest, they should be probably swapped)
Comment 15 Dan Jacobson 2011-12-14 14:22:23 UTC
Irritating, isn't it?
Comment 16 Chad H. 2011-12-14 16:04:02 UTC
Not really.
Comment 17 Antoine "hashar" Musso (WMF) 2012-01-12 10:59:31 UTC
Last one swapped with r108716.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links