Last modified: 2011-12-13 23:55:45 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T34440, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 32440 - Link to mediawiki.org in extension description should be protocol-relative
Link to mediawiki.org in extension description should be protocol-relative
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
General/Unknown (Other open bugs)
unspecified
All All
: Unprioritized enhancement (vote)
: ---
Assigned To: Brion Vibber
: patch, patch-need-review
Depends on:
Blocks: 20342
  Show dependency treegraph
 
Reported: 2011-11-16 08:45 UTC by Michael M.
Modified: 2011-12-13 23:55 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Proposed patch (1.08 KB, patch)
2011-11-21 08:17 UTC, Michael M.
Details

Description Michael M. 2011-11-16 08:45:03 UTC
At the moment all links in [[Special:Version]] have a hardcoded http: as protocol. This should be changed for every extension.
Comment 1 LordAndrew 2011-11-16 17:27:17 UTC
A number of extensions try to keep compatibility with previous versions of MediaWiki, so those would either have to be left alone or have more backward compatibility code added (fun!).
Comment 2 Michael M. 2011-11-21 08:17:42 UTC
Created attachment 9505 [details]
Proposed patch

I created a patch for Special:Version to remove the protocol there, so it doesn't break backward compatibility.
Comment 3 Daniel Friesen 2011-11-22 04:03:07 UTC
That really looks like a hack. The link on Special:Version itself (the one built in to SpecialVersion.php) should of course be tweaked. But I don't think we should hack in something like that to remove http: from MediaWiki installs (the majority of which are in fact still http anyways and don't get any advantage).

It's probably better to just wait till 1.17 becomes obsolete and extensions start dropping compat.
Comment 4 Robin Pepermans (SPQRobin) 2011-11-27 15:41:14 UTC
I changed the simple link to mediawiki.org in r104339 (found this bug after committing).
Comment 5 Brion Vibber 2011-12-13 23:36:31 UTC
Should migrate toward using https: URLs everywhere here; no need to be protocol-relative.
Comment 6 Brion Vibber 2011-12-13 23:55:45 UTC
r106140 sets the MediaWiki & viewvc links to https.

r106136 updates 562 extensions to specify https: urls instead of http: for their Special:Version links to http://www.mediawiki.org/Extension:*

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links