Last modified: 2012-02-24 02:52:49 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T34319, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 32319 - Android app doesn't allow search when webview overlaps with an image
Android app doesn't allow search when webview overlaps with an image
Status: RESOLVED FIXED
Product: Wikipedia App
Classification: Unclassified
Generic (Other open bugs)
1.0.0 (Android)
All All
: Normal normal
: ---
Assigned To: Yuvi Panda
:
Depends on:
Blocks: 31447 32917
  Show dependency treegraph
 
Reported: 2011-11-09 18:11 UTC by Tomasz Finc
Modified: 2012-02-24 02:52 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: Android
Assignee Huggle Beta Tester: ---


Attachments

Description Tomasz Finc 2011-11-09 18:11:04 UTC
Load any page with image assets. Scroll the window so that the image overlaps the search input box. Tap the search input box. You'll get an image detail page instead of the search input box.
Comment 1 herman wong 2011-11-10 19:01:53 UTC
hmmm. tried using event.stopPropagation on the search field (searchParam input)
and on the search bar (mainHeader div) but the click/touch event still
activates on the image underneath the search area.
Comment 2 herman wong 2011-11-15 18:24:33 UTC
https://github.com/nitobi/Wikipedia/commit/d92b124b28f162746fba3ba8c8de37887cfa3c32

seems to do the fix this issue, but has a slight side effect where the keyboard hides after the 1st character is typed...
Comment 3 Brion Vibber 2011-12-13 21:40:44 UTC
updated link from last comment:
https://github.com/Wikimedia/WikipediaMobile/commit/d92b124b28f162746fba3ba8c8de37887cfa3c32
Comment 4 Phil Chang 2011-12-19 18:19:46 UTC
Is this fixed? Seems to be gone in RC2.
Comment 5 Yuvi Panda 2011-12-19 20:59:32 UTC
Was very intermittently reproducable when I was checking it out a few days ago.
Comment 6 Brion Vibber 2011-12-19 22:17:22 UTC
This seems to be (mostly?) resolved by this bit in android/platform.js's onDeviceReady:

    // this disables the "click-through" of an image under the search bar - but hides the keyboard only on the first character typed...
    $('#searchParam').bind('touchstart', function () {     
        $('#searchParam').focus();
        plugins.SoftKeyBoard.show();
        return false; 
    } );


However, that appears to be the cause of bug (mumble muble -- there appear to be at least two of them) -- with the focus ring / cursor not appearing on their own when tapping into the search bar.
Comment 7 Brion Vibber 2012-01-05 01:27:25 UTC
We have some related issues with the 'W' and search icons -- is there a separate bug for em we can't find? :)
Comment 8 Brion Vibber 2012-01-06 00:36:12 UTC
Related issues should be solved by the move over to divs.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links