Last modified: 2014-09-15 13:59:18 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T34297, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 32297 - Cleanup default timezone settings to use symbolic names, not offsets
Cleanup default timezone settings to use symbolic names, not offsets
Status: REOPENED
Product: MediaWiki
Classification: Unclassified
General/Unknown (Other open bugs)
1.20.x
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
: 32282 (view as bug list)
Depends on:
Blocks: 19516
  Show dependency treegraph
 
Reported: 2011-11-08 23:31 UTC by Brion Vibber
Modified: 2014-09-15 13:59 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Brion Vibber 2011-11-08 23:31:09 UTC
From https://bugzilla.wikimedia.org/show_bug.cgi?id=19516#c4

{{REVISIONTIMESTAMP}} uses the server-wide timezone setting, which looks like
it's getting incorrectly set still through an old old system which only grabs
the current offset -- so at the moment we're actually using '120 minutes
offset' instead of 'Europe/Berlin' as the server default. D'oh!

[snip]

This bit in CommonSettings.php needs to be removed:


if ( !isset( $wgLocaltimezone ) ) $wgLocaltimezone = 'UTC';
# Ugly hack warning! This needs smoothing out.
if ( $wgLocaltimezone ) {
    $oldtz = getenv( 'TZ' );
    putenv( "TZ=$wgLocaltimezone" );
    $wgLocalTZoffset = date( 'Z' ) / 60;
    putenv( "TZ=$oldtz" );
}

... and alas similar code appears to be in Setup.php now. :P

Language::userAdjust's path through 'System' or tz being '' should probably be
pulled up and run through the date_create / date_timezone_set stuff if
$wgLocaltimezone is set, preferable to $wgLocalTZOffset.

Or at least they need to be sorted out in some way. :P
Comment 1 Beau 2012-05-04 17:04:32 UTC
I have submitted Gerrit change #6617 for review.
Comment 2 Beau 2012-07-01 16:34:25 UTC
The change has been merged.
Comment 3 Beau 2012-07-01 16:42:15 UTC
*** Bug 32282 has been marked as a duplicate of this bug. ***
Comment 4 Antoine "hashar" Musso (WMF) 2012-07-02 11:12:49 UTC
I have reverted Gerrit change #6617 with Gerrit change #13865. That broke tests horribly.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links