Last modified: 2011-11-20 11:04:12 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T33990, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 31990 - justify paragraphs pref adds extra space to category listing
justify paragraphs pref adds extra space to category listing
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Categories (Other open bugs)
1.18.x
All All
: Normal normal (vote)
: 1.18.0 release
Assigned To: Nobody - You can work on this!
http://en.wikipedia.org/wiki/Uturuncu
: easy
Depends on: 32460
Blocks: 28593
  Show dependency treegraph
 
Reported: 2011-10-27 14:02 UTC by Jason Quinn
Modified: 2011-11-20 11:04 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Shows an example of a bug and how large the space can be (128.62 KB, image/png)
2011-10-27 14:02 UTC, Jason Quinn
Details
shows the same page under Chromium (189.46 KB, image/png)
2011-10-27 14:02 UTC, Jason Quinn
Details
Screenshot without HotCat, but with the "Justify paragraphs" user preference set (253.91 KB, image/png)
2011-10-28 08:53 UTC, Lupo
Details

Description Jason Quinn 2011-10-27 14:02:08 UTC
Created attachment 9293 [details]
Shows an example of a bug and how large the space can be

The spacing before the first category (under at least Vector) can be unnaturally large after the upgrade to MediaWiki 1.18.

This bug may require HotCat to be enabled and/or may be browser dependent. I see it under Firefox 3.6.23 under Ubuntu 10.04 LTS but not not under Chromium 14.0.835.202 (Developer Build 103287 Linux) Ubuntu 10.04.
Comment 1 Jason Quinn 2011-10-27 14:02:57 UTC
Created attachment 9294 [details]
shows the same page under Chromium
Comment 2 Mark A. Hershberger 2011-10-27 19:48:16 UTC
added url of example page
Comment 3 Mark A. Hershberger 2011-10-27 19:52:45 UTC
spacing isn't there for me when I add HotCat... Could you install firebug and see what is in that space?  There is probably something else causing this.
Comment 4 Bawolff (Brian Wolff) 2011-10-28 00:38:46 UTC
Adding Lupo to cc-list. Given he appears to be the current maintainer of hotcat, I assume he'd want to know about this bug (hopefully I got the right lupo)


Also in the history of the gadget there is an edit summary: "Workaround for FF3.6 layout bug". Perhaps that's a fix for this bug(?)
Comment 5 Lupo 2011-10-28 08:38:57 UTC
Yes, you got the right Lupo.

No, the "Workaround for FF3.6 layout bug" was something else.

However, I cannot reproduce this using FF3.6.23 on Mac OS10.6. I don't see any extra space.

I also have not seen any other mention of this. Given that HotCat is used by tens of thousands of people (extrapolating from the more than 5000 alone on Commons that I know of), I usually get bug reports on-wiki pretty quickly at the Commons, or at the English or German Wikipedias. So I think this is not a general problem but something specific to Jason's setup.

Jason doesn't seem to use any user-specific JS or CSS. (At least, User:Jason_Quinn at the English Wikipedia doesn't. I hope that's the original reporter.)

Maybe caused by some other Gadget that Jason may have additionally enabled? Or client-side scripts (Greasemonkey?)?
Comment 6 Lupo 2011-10-28 08:53:17 UTC
Created attachment 9310 [details]
Screenshot without HotCat, but with the "Justify paragraphs" user preference set

It's the "Justify paragraphs" user preference, which Jason evidently has enabled.

The white space also appears without HotCat. See the attached screenshot (this time with monobook).
Comment 7 Mark A. Hershberger 2011-10-28 17:17:50 UTC
Confirmed this with justify paragraphs.  I don't know if this is a regression, though, so low priority.
Comment 8 Lupo 2011-10-29 02:36:00 UTC
Yes, it is a regression. It's caused by the change to use a UL-LI DOM for the category list; this leaves the browser with just one blank to justify the text (after "Categories:").

The change to a UL-LI DOM was sound, but text justification should now be switched off for #catlinks in CSS.
Comment 9 Bawolff (Brian Wolff) 2011-11-03 16:47:57 UTC
btw, for reference this is hardly the only thing the justify pref screws up (For example, the (next 200) links on categories - but only on the image gallery section, the Date column of special:listfiles... I'm sure you could find more if you looked.
Comment 10 Sumana Harihareswara 2011-11-04 22:41:31 UTC
Per IRC discussion today: this is a regression.  Proposed Solution is CSS/JS and may happen in more places than just the category listing. But this is probably not significant enough to be something we need to deal with before releasing MediaWiki 1.18, so, removing the 1.18 release milestone.
Comment 11 Antoine "hashar" Musso (WMF) 2011-11-07 16:17:37 UTC
tagging for 1.18 tarball
Comment 12 Sumana Harihareswara 2011-11-07 16:20:13 UTC
Per IRC conversation just now, Antoine aims to fix this.  Thus, assigning to him.
Comment 13 Antoine "hashar" Musso (WMF) 2011-11-07 16:47:28 UTC
Applied Lupo idea to skins/common/shared.css

Tested locally with Monobook and Vector and with languages French (left to right) and Arabic (right to left).

Would need a backport.
Comment 14 Antoine "hashar" Musso (WMF) 2011-11-07 17:51:21 UTC
patch was applied with r102297. It needs a backport.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links