Last modified: 2012-02-24 02:52:25 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T33973, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 31973 - Refactor Android PhoneGap app so most of the code is platform-independent
Refactor Android PhoneGap app so most of the code is platform-independent
Status: RESOLVED FIXED
Product: Wikipedia App
Classification: Unclassified
Generic (Other open bugs)
1.0.0 (Android)
All All
: High normal
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks: 31974 31975 31976 31977 31980
  Show dependency tree / graph
 
Reported: 2011-10-27 01:04 UTC by Brion Vibber
Modified: 2012-02-24 02:52 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: Android
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Brion Vibber 2011-10-27 01:04:56 UTC 
Current code mixes generic HTML / PhoneGap stuff with Android-specific things (use of android-specific plugins like the menus and sharing, etc).

Should refactor it out so we can import the common code into the Android project and also into the iPhone project without having to manually synchronize multiple code trees as much.
Comment 1 Brion Vibber 2011-10-30 23:03:38 UTC 
Pull request with work in progress:

https://github.com/nitobi/Wikipedia/pull/48

This checks whether we're running on Android or iOS and loads up the appropriate phonegap-1.1.0.js and any needed plugin interface stubs. Some of the files under js/ are split into eg js/android/ and js/ios/.


Initial iOS build stuff also included (for bug 31974) though it's not quite working right.
Comment 2 Brion Vibber 2011-10-30 23:20:46 UTC 
Has been merged as of 05e8d9d57598f4ddfd180f8d9740fe3b7f9e9d88

Still need to break out some Android-specific assumptions and code into platform-specific modules.
Comment 3 Brion Vibber 2011-10-31 02:00:48 UTC 
Done a bit further as of:

https://github.com/nitobi/Wikipedia/commit/8c9753968321723e9074cbfbc2d99115c6016d18
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links