Last modified: 2011-10-24 02:21:51 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T33740, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 31740 - (Jpeg|Gif)MetadataExtractor lacks bounds checking, spams error logs with E_WARNING
(Jpeg|Gif)MetadataExtractor lacks bounds checking, spams error logs with E_WA...
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
File management (Other open bugs)
1.18.x
All All
: High normal (vote)
: ---
Assigned To: Bawolff (Brian Wolff)
:
Depends on:
Blocks: 30961
  Show dependency tree / graph
 
Reported: 2011-10-15 22:34 UTC by Tim Starling
Modified: 2011-10-24 02:21 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Tim Starling 2011-10-15 22:34:30 UTC 
When running refreshImageMetadata.php on angwiki, I got:

Warning: unpack(): Type N: not enough input, need 4, have 0 in /usr/local/apache/common-local/php-1.18/includes/media/JpegMetadataExtractor.php on line 205

298290 times, and then I hit ctrl-C. JpegMetadataExtractor should use a wrapper around unpack that guards against reading beyond the end of the string. I made one for ZipDirectoryReader, maybe we should factor that out for the benefit of other binary format parsers.
Comment 1 Tim Starling 2011-10-15 22:35:04 UTC 
Assigning to Bawolff.
Comment 2 Chad H. 2011-10-15 22:51:31 UTC 
Expanding summary, also happens with GifMetadataExtrator.
Comment 3 Bawolff (Brian Wolff) 2011-10-18 12:44:19 UTC 
(btw, I probably won't have time to fix this until the weekend)
Comment 4 Bawolff (Brian Wolff) 2011-10-24 02:21:08 UTC 
fixed in r100572.


I think [[ang:File:Handsprecan.jpg]] might have been the specific file in question causing the issue (It has some metadata inside it that looks invalid), but I wasn't able to re-produce the massive number of warnings on my local install, so I don't really know for sure if it was that file or something else.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links