Last modified: 2012-02-24 02:52:07 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T33705, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 31705 - Android app should not show a confirm bookmarks dialog
Android app should not show a confirm bookmarks dialog
Status: RESOLVED FIXED
Product: Wikipedia App
Classification: Unclassified
Generic (Other open bugs)
1.0.0 (Android)
All All
: Normal normal
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks: 31447
  Show dependency tree / graph
 
Reported: 2011-10-14 20:02 UTC by Tomasz Finc
Modified: 2012-02-24 02:52 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: Android
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Tomasz Finc 2011-10-14 20:02:29 UTC 
Just add the bookmark and do a quick notification at the bottom of the screen saying 'Bookmark Added'. 

http://meta.wikimedia.org/wiki/File:Wiki_0004_Article_BookmarkAdded.png
Comment 1 Brion Vibber 2011-10-26 22:16:10 UTC 
Pull request: https://github.com/nitobi/Wikipedia/pull/40

Commits in this branch pull in the PhoneGap-Toast plugin to allow use of Android's lightweight "Toast notifications" -- these show briefly on screen but are non-modal, and is the same as the stock Android Browser uses to tell you you've added a bookmark.

Switched adding bookmarks from a confirmation prompt to just showing you the notification; switched deleting bookmarks from an alert() prompt after confirmation and deletion into a lightweight toast notification after confirmation and deletion.

Also i18n-ify'd the related UI strings; added English versions and qqq descriptions.
Comment 2 herman wong 2011-10-26 23:06:51 UTC 
https://github.com/nitobi/Wikipedia/commit/6d02d6a7a21c539eb43ecbf103a357166d87279c

the change has been merged into the main repo.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links