Last modified: 2012-02-24 02:52:29 UTC
If we fail to retrieve data from a network the view just shows a blank page. You can access buttons but can't reload the page in any way.
Anis, can you include a link to the commit that resolves this please? Thanks!
https://github.com/nitobi/Wikipedia/commit/e4cd16da9edcbfe75793ca9d064519c6d13a4c60
That commit has the comment "fixing nearme returned urls"; is that also a general fix for the above-noted network errors?
Yes it should be. Trying disabling your network connection and launch the app.
The reason I ask is that that commit only changes the NearMeActivity and WikiItemizedOverlay Android plugin pieces, and tweaks the width of a textview. As far as I know none of these activities are in use when we start the app?
It is actually an earlier commit https://github.com/nitobi/Wikipedia/commit/eea4be11efc3d22c3981679becb29ccc03d6d665 but it works with the latest revision of master I basically added a timeout and an error handler
Thanks. Please always point to the actual revisions which actually make changes, otherwise we can't tell what you're talking about and it makes review and maintenance a lot harder. What's with replacing jQuery with this Zepto thing? Why is that done together with a stop button? Is that a requirement? Are there any other benefits? Please be sure to document such things when making changes!
Sorry about that... Zepto is a much lighter version of jQuery optimized for mobile. jQuery has a lot of desktop browser specific code (IE 6 specific code for instance) that we don't need for mobile. The syntax is the same. It is missing some jQuery functions but the main ones are supported. It also includes some other functions only available on webkit mobile. https://github.com/madrobby/zepto The stop button change is totally unrelated to Zepto. I just happened to make both changes at the same time. I will from now on submit the commit url every time I update a ticket to RESOLVE. Apologies...
