Last modified: 2012-02-24 02:52:42 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T33686, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 31686 - Android app should show search suggestions
Android app should show search suggestions
Status: RESOLVED FIXED
Product: Wikipedia App
Classification: Unclassified
Generic (Other open bugs)
1.0.0 (Android)
All All
: Normal enhancement
: ---
Assigned To: herman wong
:
Depends on:
Blocks: 31447
  Show dependency treegraph
 
Reported: 2011-10-14 02:47 UTC by Tomasz Finc
Modified: 2012-02-24 02:52 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: Android
Assignee Huggle Beta Tester: ---


Attachments

Description Tomasz Finc 2011-10-14 02:47:11 UTC
Just like the desktop site. Text input on mobiles suck so lets make it easier by making our users type less.
Comment 1 Tomasz Finc 2011-10-14 03:10:40 UTC
Let's re-use whatever we come up with for https://bugzilla.wikimedia.org/show_bug.cgi?id=19956
Comment 2 Anis Kadri 2011-10-21 18:31:12 UTC
latest master
Comment 3 Brion Vibber 2011-10-21 18:31:58 UTC
What about latest master?
Comment 4 Anis Kadri 2011-10-21 18:43:50 UTC
Sorry mistake :/
Comment 5 Brion Vibber 2011-10-31 02:26:36 UTC
Ok, current state is:

* there are no suggestions while you type
* when you submit your search, instead of an actual search we look up the search suggestions based on what you typed.

So basically we need to take the suggestion search that it does now and move that to *while you type*, and then change the final search to do a fulltext search instead of getting typeahead suggestions.
Comment 6 herman wong 2011-11-02 21:52:26 UTC
https://github.com/nitobi/Wikipedia/commit/435256ffbc1ffc653364be13c7564cdbd1607697

search suggestions display as the user types
Comment 7 Brion Vibber 2011-11-02 21:59:30 UTC
Seems pretty buggy:
* sometimes comes back with seemingly wrong or early results: eg typing "thing" and ending up with suggestions that fit with just the initial "t"
* sometimes all the results disappear from screen
* sometimes navigates to a page before you've completed the search; for instance type "supreme" or "new york" and you may find yourself at those pages.
Comment 8 Brion Vibber 2011-11-02 22:02:24 UTC
Tapping on a suggestion also often closes the list without showing any focus behavior in the list, then focuses & shows a highlight ring on some UI element that was on the page behind, such as a link, until the target page loads.
Comment 9 herman wong 2011-11-02 23:12:07 UTC
https://github.com/nitobi/Wikipedia/commit/3d429186f9881a6db767040adefb274eccc60d85

this should fix the following symptoms:

* sometimes all the results disappear from screen
* sometimes navigates to a page before you've completed the search; for
instance type "supreme" or "new york" and you may find yourself at those pages.
Comment 10 Brion Vibber 2011-11-02 23:23:13 UTC
Awesome, it's working a lot smoother now. A little tweaking on the click behavior should pretty much do it for now!
Comment 11 herman wong 2011-11-07 22:37:32 UTC
https://github.com/nitobi/Wikipedia/commit/205829daf164d3e8191b9f33cb5a71a57f059cf3

this should prevent the focus on UI element on the page behind.
Comment 12 herman wong 2011-11-08 01:24:16 UTC
https://github.com/nitobi/Wikipedia/commit/8c19042190985ddd504173458620c6166999abf7

the search results & search suggestions now have an active state when the item is clicked on.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links