Last modified: 2014-02-12 23:52:30 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T33591, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 31591 - Inline styles: Wikipedia:Contact us page is horribly formatted - new contact/feedback page
Inline styles: Wikipedia:Contact us page is horribly formatted - new contact/...
Status: RESOLVED FIXED
Product: MobileFrontend
Classification: Unclassified
stable (Other open bugs)
unspecified
All All
: Normal normal
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks: inline-styles 33855
  Show dependency treegraph
 
Reported: 2011-10-10 18:18 UTC by Sam Reed (reedy)
Modified: 2014-02-12 23:52 UTC (History)
12 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Sam Reed (reedy) 2011-10-10 18:18:39 UTC
The footer is shown near the top

Bullet point lines are shown in the middle of the page, and only one word per line
Comment 1 Brion Vibber 2011-10-10 20:18:36 UTC
IIRC it's pulling up a non-mobile-formatted view and it renders pretty badly in the tiny iframe.
Comment 2 Tomasz Finc 2011-10-10 20:21:04 UTC
Yes. This is going to require some content work to make it mobile friendly. Any objection to opening up a content component ?
Comment 3 Sam Reed (reedy) 2011-10-11 00:59:36 UTC
(In reply to comment #2)
> Yes. This is going to require some content work to make it mobile friendly. Any
> objection to opening up a content component ?

Seems sensible..
Comment 4 Phil Chang 2012-01-26 18:23:38 UTC
Other UI work will likely result in not fixing this, but providing a button to a new contact/feedback page.
Comment 5 Jon 2012-04-02 19:36:45 UTC
The problem is inline styles in the contact page.
I'm not sure how we get round this sort of thing (which I'm noticing a lot on the mobile site where pages assume they are always on desktop - also see bug 30406)

One possible solution I can think of is scrubbing inline styles of any element marked with a class no-mobile-styling which would empower admins a generic way to fix this sort of thing.

A second solution (at least for this page) would be to force a redirect to the desktop site, especially taking Phil's comments and [1] into account.

Thoughts?

[1] http://www.mediawiki.org/wiki/Mobile_design/Contact
Comment 6 Tomasz Finc 2012-04-04 05:34:56 UTC
So there are two separate issues here.

1) two column layouts suck on mobile. we need to restyle these anytime it happens. on any page
2) the current contact us page is not actually useful for a mobile device. the only points that make any sense right now to keep are article quality related. 

Let's move forward with the ideas in the contact us form and then table the two column layout discussion for now.
Comment 7 Phil Chang 2012-04-04 06:20:41 UTC
Just to clarify, the new Contact form is a highly condensed form of this page, intended to simplify and reduce the actions a user could take. So the new page is all the user would see in Mobile View. The Contact page on the main site would only appear in Desktop View. In the case of this page, it would be nice if we could force a re-direct to the Mobile View (formatting issues aside)!
Comment 8 Jon 2012-04-04 11:02:19 UTC
The problem is that these 2 column layouts are hard to detect as they use inline styles rather than styling via Common.css . I would suggest some refactoring of the content rather than changing the mobile site to deal with this.

I'm not so keen on the idea of a redirect.
http://en.wikipedia.org/wiki/Wikipedia:Contact_us is not the same as the new contact form. They are separate pages. If I link to Wikipedia:Contact_us in an article there may be a good reason. For example I might write in an article 'To report a copyright violation see the other matters section on the [[Wikipedia::Contact_us|Contact us]] page. If the user is then redirected to the mobile page this sentence no longer carries meaning. It is for that reason I think that instead of redirecting we should simply ensure that when users go to http://en.wikipedia.org/wiki/Wikipedia:Contact_us they always get the desktop site. This is my opinion is the **right** thing to do.
Comment 9 Jon 2012-04-04 11:05:24 UTC
(.. or if we can sort out the 2 column layout problem via common.css and class changes do not force the redirect at all and show them the normal contact us page)
Comment 10 Phil Chang 2012-04-04 15:09:09 UTC
Sorry Jon, I was making the point about re-direction in jest. Hence the exclamation point. You are right, we need to deal with inline styles in general, but probably not in the context of this bug.

It might be a good idea to open a new bug about inline styles, especially as they pertain to 2-column layouts.
Comment 11 Tomasz Finc 2012-04-04 17:56:17 UTC
We already have bugs that discuss poor two column layouts - https://bugzilla.wikimedia.org/show_bug.cgi?id=31591
Comment 12 Jon 2012-04-05 15:24:40 UTC
I think you posted the wrong bug Tomasz that points to this one!
Comment 13 Tomasz Finc 2012-04-05 17:51:34 UTC
(In reply to comment #12)
> I think you posted the wrong bug Tomasz that points to this one!

FAIL! https://bugzilla.wikimedia.org/show_bug.cgi?id=30887 :)
Comment 14 Jon 2012-04-20 13:54:20 UTC
Marking this as another example of inline styling problems see bug 35704
Comment 15 Jon 2012-05-15 11:54:14 UTC
Suggested solution at http://en.wikipedia.org/wiki/Wikipedia_talk:Contact_us#Bug_31591 - can someone fix?

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links