Last modified: 2012-01-03 21:51:21 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T33509, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 31509 - Run a cleanup bot over all EXIF-rotated images on Commons, other wiki sites
Run a cleanup bot over all EXIF-rotated images on Commons, other wiki sites
Status: RESOLVED FIXED
Product: Wikimedia
Classification: Unclassified
General/Unknown (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Sam Reed (reedy)
: platformeng
Depends on:
Blocks: 31504
  Show dependency treegraph
 
Reported: 2011-10-07 23:08 UTC by Brion Vibber
Modified: 2012-01-03 21:51 UTC (History)
8 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Brion Vibber 2011-10-07 23:08:07 UTC
A general refreshImageMetadata run on the server should help, but we also need to check for problems such as mistagged images. I'll see if I can whip up a bot to run through and build a report...
Comment 1 Platonides 2011-10-08 21:59:07 UTC
What 'cleanup' is it supposed to do?
Undo all rotations automagically performed due to EXIF?
Comment 2 Pikne 2011-12-09 09:05:32 UTC
Would it be possible to query all images that have EXIF orientation other than "Normal/1" and were uploaded before deploying MW 1.18? Their thumbnails are now autorotated though physical images are probably straight. If so, would it be possible to reset or remove their orientation tags directly in database (that kind of cleanup) so that they weren't autorotated without being needed? Rotabebot on Commons is slowly resetting these now (reset for over 4000 images in the past days and the queue is lengthening). If possible to clean up the database that way, should be ensured that Rotatebot wouldn't rotate images in queue once nothing to reset.

Unless just undoing autorotation feature and redoing it per bug 32875 so that the images were asked to be physically rotated per EXIF data while being upload and without confusion that later thumbs are straight and physical image is not or vice versa.

That's my ideas after seeing quite some people disturbed on projects as their previously uploaded straight images are now on side or upside down. Sorry if I miss something important.
Comment 3 Saibo 2011-12-09 12:56:48 UTC
(In reply to comment #2)
> Would it be possible to query all images that have EXIF orientation other than
> "Normal/1" and were uploaded before deploying MW 1.18?

Did you know this?
http://commons.wikimedia.org/wiki/Commons:Bots/Work_requests#Maintenance_category_for_files_with_EXIF_rotation_other_than_0_degrees
Comment 4 Rob Lanphier 2011-12-13 17:29:44 UTC
Assigning to Sam to work with Luxo and others and investigate whether anything can/should be done to speed up the process.  See http://commons.wikimedia.org/wiki/User:Rotatebot for more info about the existing Rotatebot solution, and http://commons.wikimedia.org/wiki/Commons_talk:Rotation as the hub for on-wiki conversation about this topic.
Comment 5 Saibo 2011-12-13 20:02:02 UTC
(In reply to comment #4)
> Assigning to Sam to work with Luxo and others and investigate whether anything
> can/should be done to speed up the process.  See

For the next deploy of such a feature: the about 50k files should have been fixed before this had been deployed. ;-) 

In addition to your link: If there are questions about Rotatebot: just post on its talk page.  If there are questions/ideas for a systematic approach, as said, the existing topic at the bots request is the best place.
Comment 6 Tim Starling 2011-12-14 00:55:36 UTC
I tried to run refreshImageMetadata.php on all wikis after the 1.18 deployment, see bug 30961. I stopped because of a memory leak. I don't think it's a good idea to run it now, since it would only exacerbate the autorotation issue.
Comment 7 Rob Lanphier 2011-12-15 19:18:09 UTC
Reedy has been working with Saibo and Luxo here: http://commons.wikimedia.org/wiki/User_talk:Rotatebot#Rotatebot_and_the_WMF
Comment 8 Sam Reed (reedy) 2011-12-19 22:18:26 UTC
This has gone back to being run on Toolserver after Mark fixing a LVS regression with regards to upload speed.

I do have a clone bot on hume, but as the speed for uploads back from the toolserver is much nicer, this was stopped.

Seems there's a backlog building up, so worth keeping an eye on. Rotatebot is still running at a decent speed according to [1]

Lowering priority to normal for the time being

[1] http://commons.wikimedia.org/w/index.php?limit=50&tagFilter=&title=Special%3AContributions&contribs=user&target=Rotatebot
Comment 9 Bawolff (Brian Wolff) 2011-12-19 22:23:48 UTC
Perhaps I'm missing something, but I don't see how refreshImageMetadata.php would affect anything (in relation to this bug). We've been extracting rotation metadata in (almost) the same way since MediaWiki 1.5.
Comment 10 Tim Starling 2011-12-19 22:26:45 UTC
(In reply to comment #9)
> Perhaps I'm missing something, but I don't see how refreshImageMetadata.php
> would affect anything (in relation to this bug). We've been extracting rotation
> metadata in (almost) the same way since MediaWiki 1.5.

Yes, that's true. It was the thumbnail cleanup script that Ariel ran that made this problem especially obvious.
Comment 11 Rob Lanphier 2012-01-03 21:51:21 UTC
RotateBot seems to be pretty much caught up now, and will probably be able to keep up with whatever remaining rotation requests come along.  Marking as fixed for lack of more appropriate state.  :)

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links