Last modified: 2011-10-15 22:03:17 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T33496, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 31496 - Error messages are described as warnings


Summary:	Error messages are described as warnings

Status:	RESOLVED FIXED

Product:	MediaWiki
Classification:	Unclassified
Component:	Uploading (Other open bugs)
Version:	1.20.x
Hardware:	All All

Importance:	Highest normal (vote)
Target Milestone:	---
Assigned To:	Nobody - You can work on this!

URL:
Whiteboard:
Keywords:	need-integration-test, patch, patch-need-review

Depends on:
Blocks:	29876
	Show dependency tree / graph

Reported:	2011-10-07 15:11 UTC by Tomer A.
Modified:	2011-10-15 22:03 UTC (History)
CC List:	4 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Patch (35.46 KB, patch) 2011-10-10 16:32 UTC, Tomer A.	Details
Unified diff? (498 bytes, patch) 2011-10-11 16:48 UTC, Tomer A.	Details
patch, unified diff (498 bytes, patch) 2011-10-11 17:22 UTC, Tomer A.	Details
SVN diff, as Per Amir's request. (547 bytes, patch) 2011-10-13 14:12 UTC, Tomer A.	Details
Show Obsolete (3) Add an attachment (proposed patch, testcase, etc.)

Description Tomer A. 2011-10-07 15:11:57 UTC

When file name contains characters which are not permitted the upload form shows a warning message while in fact this is a blocking error.

Comment 1 Tomer A. 2011-10-10 16:32:26 UTC

Created attachment 9209 [details]
Patch

Changed the description from warning to error (string already existed). As far as I can tell, this method (showRecoverableUploadError) is never called by warnings, only by errors (MIN_LENGTH_PARTNAME, ILLEGAL_FILENAME, FILENAME_TOO_LONG, FILETYPE_MISSING, WINDOWS_NONASCII_FILENAME and verifyTitlePermissions). 

This is my first patch, please be gentle.

Comment 2 Bawolff (Brian Wolff) 2011-10-11 13:04:49 UTC

Any chance the patch could be attached in unified diff format ([[w:Diff#Unified_format]]). 

Thanks.

Comment 3 Tomer A. 2011-10-11 16:48:44 UTC

Created attachment 9218 [details]
Unified diff?

Like that?

Comment 4 Tomer A. 2011-10-11 17:22:22 UTC

Created attachment 9219 [details]
patch, unified diff

Better yet.

Comment 5 Bawolff (Brian Wolff) 2011-10-11 19:29:12 UTC

(In reply to comment #4)
> Created attachment 9219 [details]
> patch, unified diff
> 
> Better yet.

Yep, that's much better.

Comment 6 Tomer A. 2011-10-13 14:12:21 UTC

Created attachment 9227 [details]
SVN diff, as Per Amir's request.

Comment 7 Amir E. Aharoni 2011-10-13 16:49:18 UTC

Patch applied in r99700 (what a nice number).

Thank you.

Comment 8 Mark A. Hershberger 2011-10-15 22:03:17 UTC

tagging bugs for Marcus to look at

Note You need to log in before you can comment on or make changes to this bug.

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links