Last modified: 2012-02-24 02:52:41 UTC
There seems to be a modal spinner shown on the initial 'main page' load and when submitting searches, but no spinner at all on page-to-page navigation. Modal spinners should be avoided if possible; better to show something inline that leaves the UI active and has a way to cancel it.
Need to trap navigation events within the iframe.
https://github.com/nitobi/Wikipedia/tree/2774232d55c2ade7d80e04ae268ede3f1e95c1e2 Added the UI component for this. Use showSpinner() / hideSpinner() to bring it up.
This looks like a plain animated GIF, which doesn't work on all Android builds: http://code.google.com/p/android/issues/detail?id=3422 Will this reliably work or do we need to do a sprite-style image that animates with a timeout or something?
*** Bug 31952 has been marked as a duplicate of this bug. ***
added spinner animation https://github.com/nitobi/Wikipedia/commit/8c53605c20fcd65694c5612b3b69704cee9d29c3 currently it only activates on initial load of the app, search, navigating to search results / bookmarks / history items.
Initially thought we could use this Android API to capture link clicks in the iframe: http://developer.android.com/reference/android/webkit/WebViewClient.html#onPageStarted%28android.webkit.WebView,%20java.lang.String,%20android.graphics.Bitmap%29 but it looks like it only works for the main frame and not the iframe.
this should fix it. let me know if it doesn't https://github.com/nitobi/Wikipedia/commit/4169c622bdb2aceee8fc68cd2ebb36270a3beed9
seems to work for me. tested on Android 2.3.6 Nexus S.
On my Nexus 1 w/ Android 2.3.6 I see a spinner when submitting a query from search results, but not during page loads in regular navigation (the subject of this bug). Reopening.
Ok, can confirm it *is* showing the spinner on regular navigation as of my current working state: https://github.com/nitobi/Wikipedia/commit/8c9753968321723e9074cbfbc2d99115c6016d18 Must have been one of those "Eclipse doesn't see your new files" things. ;)
It exists, but doesn't actually seem to spin - is just 'stuck' in one position during the entire duration of the load.
I've broken out the 'doesn't spin on all devices due to limited animated GIF support' issue to bug 33198; reclosing this one.
