Last modified: 2012-02-24 02:52:28 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T33472, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 31472 - Android app menu buttons are sometimes all/mostly grayed out
Android app menu buttons are sometimes all/mostly grayed out
Status: RESOLVED FIXED
Product: Wikipedia App
Classification: Unclassified
Generic (Other open bugs)
1.0.0 (Android)
All All
: High blocker
: ---
Assigned To: herman wong
:
Depends on:
Blocks: 31447
  Show dependency treegraph
 
Reported: 2011-10-07 02:36 UTC by Brion Vibber
Modified: 2012-02-24 02:52 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: Android
Assignee Huggle Beta Tester: ---


Attachments

Description Brion Vibber 2011-10-07 02:36:47 UTC
Have seen all buttons, or all but bookmarks, grayed out a number of times. Not sure how to repro the state.

Nexus 1, Android 2.3.6
Comment 1 herman wong 2011-10-11 22:02:46 UTC
this happens depending on which view you are on.

for example if you are in the view all bookmarks - everything except for history is disabled.

if you are in the view history - everything except the view all bookmarks is disabled.

we can easily modify it so that all items are enabled in all views if that is the desired behavior.
Comment 2 Brion Vibber 2011-10-11 22:11:48 UTC
I would strongly recommend that at least totally independent top-level actions like 'bookmarks', 'history', 'nearby', and 'settings' either always be available, or be removed from the menu when they're not reachable.

Compare with the stock Android browser app -- when you go into the Bookmarks or History views, you get a different menu with only items that are relevant to that view. ('Bookmark last viewed page', 'List options' for Bookmarks and 'Clear History' for History).

It's a lot clearer that way that to get to other parts of the app you'll have to exit from the specialized view.
Comment 3 herman wong 2011-10-11 23:25:33 UTC
I've enabled the top-level actions regardless of the view.

https://github.com/nitobi/Wikipedia/commit/067b66d4509e445d751c3fdfb39657a9e4cfd0c5

Currently the menu-plugin is unable to remove items; this feature is in the menu-plugins roadmap but we haven't had the resourcing available to implement it.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links