Last modified: 2012-02-24 02:52:23 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T33457, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 31457 - Expand Android app to support more localized content/input
Expand Android app to support more localized content/input
Status: RESOLVED FIXED
Product: Wikipedia App
Classification: Unclassified
Generic (Other open bugs)
1.0.0 (Android)
All All
: Normal enhancement
: ---
Assigned To: herman wong
:
Depends on: 31462
Blocks: 31447
  Show dependency treegraph
 
Reported: 2011-10-07 00:29 UTC by Tomasz Finc
Modified: 2012-02-24 02:52 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: Android
Assignee Huggle Beta Tester: ---


Attachments

Description Tomasz Finc 2011-10-07 00:29:50 UTC
Font rendering and text input (e.g. for search) work for the languages & scripts supported in the device. Default language is the one used in the device.
Registered user can change preferred language in Settings.

First filed at: https://github.com/nitobi/Wikipedia/issues/14
Comment 1 herman wong 2011-10-24 21:44:35 UTC
https://github.com/nitobi/Wikipedia/commit/cc682f1b0deab86bd02de2feac1022027c4c6318

added ability to change the locale and save the last locale used.
Comment 2 herman wong 2011-10-24 22:32:33 UTC
https://github.com/nitobi/Wikipedia/commit/c4b608320d9be2e1abb737ab4415717f8d14f081

ensure that search results use the current locale
Comment 3 Brion Vibber 2011-10-25 22:33:40 UTC
'The URL could not be found. (http://en-us.m.wikipedia.org/)' .... not so good perhaps :)
Comment 4 herman wong 2011-10-25 22:45:09 UTC
can you provide some more details on how you were able to get it to build the url with the "en-us"?

was it on initial load of a new build? which browser are you using?

on the app's initial load (if the user hasn't set a locale before) the app uses navigator.language to determine the language code to use when building out the url. in the default android browser (android 2.3.6) it is returning "en".

when the locale is changed in the settings it is using the code property of the locale which is returned in the api call from http://en.wikipedia.org/w/api.php?action=sitematrix&format=json
Comment 5 herman wong 2011-10-25 23:00:01 UTC
it looks like some browsers return "en-us" or 'en_US" instead of just the "en" when using the navigator.language API.
Comment 6 herman wong 2011-10-26 19:49:15 UTC
https://github.com/nitobi/Wikipedia/commit/5b3c339c51a96bf7375d56008f48ac86be6cf533

added a method that removes the country code from navigator.language

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links