Last modified: 2011-10-15 22:03:02 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T33430, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 31430 - webkit problems with reftool site JS on en.wikipedia
webkit problems with reftool site JS on en.wikipedia
Status: RESOLVED INVALID
Product: Wikimedia
Classification: Unclassified
General/Unknown (Other open bugs)
unspecified
All All
: Normal normal with 1 vote (vote)
: ---
Assigned To: Nobody - You can work on this!
: need-integration-test
Depends on:
Blocks: 29876
  Show dependency treegraph
 
Reported: 2011-10-06 14:29 UTC by Mark A. Hershberger
Modified: 2011-10-15 22:03 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Mark A. Hershberger 2011-10-06 14:29:30 UTC
From [[WP:VPT#Reftool 1.0 failing when filling fields from URL]]:

 I use Reftools 1.0 because it can grab data and fill in fields when given the source URL. When I use it today, instead of filling in the fields, I find that I'm no longer in edit more and I'm looking at the "Read" version of the article. The browser is Chrome.
 I have the same problem, not just in Chrome but also in Safari.
Comment 1 Brion Vibber 2011-10-06 18:12:11 UTC
What's reftools? Is it a gadget or someone's user script?
Comment 2 Mark A. Hershberger 2011-10-06 18:29:19 UTC
I believe people are referring to [[User:Mr.Z-man/refToolbar]] which, as the docs point out, is now part of the wikieditor's toolbar.  See [[File:RefTools.ogv]] for more info.
Comment 3 Brion Vibber 2011-10-06 18:32:43 UTC
This looks like some sort of local site JS or gadget that plugs into WikiEditor; there's no sign of it in WikiEditor's source.
Comment 4 Mark A. Hershberger 2011-10-06 18:33:24 UTC
Hrm... Reedy/Roan tell me it is a local mod.  Sorry for the noise.
Comment 5 Brion Vibber 2011-10-06 18:37:25 UTC
https://en.wikipedia.org/w/index.php?title=MediaWiki:RefToolbar.js etc

If the problem exists, no sense closing the bug. Reassigned to general Wikimedia group as it's not part of WikiEditor ext.
Comment 6 Brion Vibber 2011-10-06 18:41:12 UTC
Can you provide a sample source URL to use and exact steps to reproduce? I'm not sure where to put a URL for it to "grab data"...
Comment 7 Joe Decker 2011-10-07 03:22:25 UTC
I got asked for a test case.  The simplest example is this:

- Make sure reftools is enabled
- Make sure " Enable enhanced editing toolbar " is *disabled* in editing prefs.  
- Edit an article (sandbox or whatever is fine)
- Press the square "cite" button
- Press the "Book" button.  Note that a "form" appears.
- Insert the following URL in the URL field:

http://books.google.com/books?id=ke02t2OyPDsC&pg=PT7&dq=we+were+somewhere+around+barstow+on+the+edge+of+the+desert&hl=en&ei=RG6OTuvcFYeqsQK8-8GaAQ&sa=X&oi=book_result&ct=result&resnum=1&sqi=2&ved=0CC0Q6AEwAA#v=onepage&q=we%20were%20somewhere%20around%20barstow%20on%20the%20edge%20of%20the%20desert&f=false

(Most results from any Google Book search should suffice.)

- Press he green icon to the right of the URL field.

EXPECTED RESULT:

   After a delay, many of the other fields in the form that pops up should be filled in, but the "form" that appeared when we pressed the Book button is left up.  (After this, you should be able to press "Add citation" to have wikimarkup for the reference inserted into the article, which should close the form but insert the newly created reference in the text at the text insertion point, but I can't get that far right now.)

OBSERVED RESULT AFTER UPGRADE:

   The page is refreshed, the form is closed, the URL and other fields are not inserted in the 



====

The "News" option works similarly, but does its best work with a subset of New York Times articles, the "Books" use case I gave above is the probably the best single test case I can come up with.)

Feel free to drop me a note on my talk page (I'm on enwiki as "Joe Decker") if I can be of any assistance.

Thanks!

--j
Comment 8 whpq 2011-10-07 12:20:57 UTC
I was the editor who reported the problem originally.  Joe Decker has described the problem, expected results, and actual results perfectly.  That is exactly the same thing that is happening to me.  I am available to provide additional info or assist as well.  I'm on enwiki as "whpq"
Comment 9 Derk-Jan Hartman 2011-10-09 20:52:31 UTC
This is a weird one. It seems the input type="image" triggers the submit action for some reason. If i change it to type="button", the problem is gone...
Comment 10 Derk-Jan Hartman 2011-10-09 21:29:52 UTC
Right, an input=image IS a submit action. So probably before there was a bug in jquery that intercepted the submit action, this bug was fixed, and the Reftools script now behaves 'as it ought to' only is that not the desired behavior. Will fix the script to cancel the event.
Comment 11 Mark A. Hershberger 2011-10-12 20:29:23 UTC
I *think* this is still being reported: http://en.wikipedia.org/w/index.php?diff=455243842

Have you had a chance to do anything with this yet?
Comment 12 Joe Decker 2011-10-12 23:02:33 UTC
I am now seeing the issue I described as "fixed".  The URL I provided above works with the cite book template, and the following URL works with the cite news template:

   http://query.nytimes.com/gst/fullpage.html?res=9A02EFD81438F936A35755C0A9639C8B63&pagewanted=2

I have not (yet) looked at the link Mark provided in the comment immediately above.
Comment 13 Mark A. Hershberger 2011-10-13 19:52:12 UTC
Cut-n-paste from WP:VPT: "The cite button in the toolbar. Cite book and web don't look up the information anymore. Instead, it submits the form and I end up saving an edit I was only halfway done with."
Comment 14 Mark A. Hershberger 2011-10-15 22:03:02 UTC
tagging bugs for Marcus to look at

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links