Last modified: 2011-10-17 20:10:41 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T33405, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 31405 - Pre-load block reason
Pre-load block reason
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
User blocking (Other open bugs)
1.18.x
All All
: Normal enhancement with 1 vote (vote)
: ---
Assigned To: Nobody - You can work on this!
: need-integration-test, patch, patch-need-review
Depends on:
Blocks: 29876
  Show dependency treegraph
 
Reported: 2011-10-06 02:39 UTC by Mark A. Hershberger
Modified: 2011-10-17 20:10 UTC (History)
7 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Patch to properly handle the form default value for HTMLSelectAndOtherField (594 bytes, patch)
2011-10-10 19:20 UTC, Brad Jorsch
Details

Description Mark A. Hershberger 2011-10-06 02:39:18 UTC
When changing a block, the block reason used to pre-load into the "reason" box on [[Special:Block]]. This seems to have been changed – now the reason box remains blank when you wish to change a block. (e.g. [http://en.wikipedia.org/wiki/Special:Block/95.76.70.248]) Could this be changed back?
Comment 1 Mark A. Hershberger 2011-10-06 19:47:33 UTC
http://en.wikipedia.org/w/index.php?diff=next&oldid=454279133

Normally, when deleting a CSD-tagged page the reason in the tag is automatically preloaded when one goes to delete the page. Doesn't seem to be happening today.
Comment 2 Aaron Schulz 2011-10-07 06:16:49 UTC
Hmm. I'm not sure what way is actually better.
Comment 3 xenocidic 2011-10-07 12:51:28 UTC
It is better if the previous reason is preloaded.

It is easier to delete a preloaded reason than to copy-and-paste it from before.

Please restore to past state.
Comment 4 Happy-melon 2011-10-07 13:00:19 UTC
I very much doubt these are the same phenomenon: the new SpecialBlock interface uses HTMLForm while the delete interface is still horrible hardcoded crappery in Article::confirmDelete().
Comment 5 Happy-melon 2011-10-07 13:04:39 UTC
(In reply to comment #1)
> http://en.wikipedia.org/w/index.php?diff=next&oldid=454279133
> 
> Normally, when deleting a CSD-tagged page the reason in the tag is
> automatically preloaded when one goes to delete the page. Doesn't seem to be
> happening today.

Plus this is done by some JS trickery on enwiki, not anything in the default software.  And it seems to be fixed now.
Comment 6 Brad Jorsch 2011-10-10 19:20:25 UTC
Created attachment 9211 [details]
Patch to properly handle the form default value for HTMLSelectAndOtherField

The problem with Special:Block is that HTMLSelectAndOtherField's loadDataFromRequest method doesn't parse the form's default value into the 'select' and 'text field' components, instead returning just the 'combined' value. And its getInputHTML method ignores the 'combined' value in favor of the 'select' and 'text field' components.

An easy fix is to just put "other" for the 'select' component and the default as the 'text field' component. Or we can go one better and actually split it apart, as in the attached patch.
Comment 7 Mark A. Hershberger 2011-10-15 22:02:57 UTC
tagging bugs for Marcus to look at
Comment 8 Brad Jorsch 2011-10-17 15:09:19 UTC
Reopening as this does not appear to be fixed on trunk (as of r100035).
Comment 9 Happy-melon 2011-10-17 16:16:46 UTC
Patch applied in r100049.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links